From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753704AbcESHDg (ORCPT ); Thu, 19 May 2016 03:03:36 -0400 Received: from nbd.name ([46.4.11.11]:34603 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcESHDf (ORCPT ); Thu, 19 May 2016 03:03:35 -0400 Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver To: Alexander Stein References: <1463587403-26809-1-git-send-email-alexander.stein@systec-electronic.com> <573C9738.4040402@gmail.com> <2a059454-279b-4ade-6f0e-837013bb323f@phrozen.org> <1712340.89M2Ezzzk6@ws-stein> Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, Mathias Kresin , "Mehrtens, Hauke" From: John Crispin Message-ID: <5f2d9a6d-bcf1-5aa1-7c45-f8cfd723bc3a@phrozen.org> Date: Thu, 19 May 2016 09:03:26 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1712340.89M2Ezzzk6@ws-stein> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ changing haukes mail addr to the intel one ] On 19/05/2016 08:57, Alexander Stein wrote: > Hi John, > > On Thursday 19 May 2016 06:50:56, John Crispin wrote: >> On 18/05/2016 18:24, Florian Fainelli wrote: >>> CC'ing Andrew, John, >> >> also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for >> several years that seems a little more complete than this one. >> >> https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/lantiq/patc >> hes-4.4/0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch;h=93bb4275ec1d261f3 >> 98afb8fdc879c1dd973f997;hb=HEAD > > Thanks for the link, I wasn't aware of that patch. I like it in general, but > there are some things I'd like to get addressed first: > * vr9_gphy_of_reg_init() writes uncoditionally to led3h and led3l even on > PEf7071 which does not have this register at all we use this driver mainly on the 11g and 22f version. mathias recently added the led3 handling. @Mathias, can you have a look at this and fix it inside the lede tree ? > * Why is PHY_HAS_INTERRUPT commented out everywhere? legacy code, the old mips silicon had a bug and the internal phys irq lines worked unreliably so we used polling instead. rather than remove the code i just disabled that part. code is not cleaned up yet for upstream submission as you can tell :-) > * ltq_phy_init and ltq_phy_exit can be simplified using phy_drivers_register > and phy_drivers_unregister yes, this driver is based on a version made by daniel from spharion about 5 years ago. that api probably did not exist at the time > * A mdio_device_id table is missing same as previous answer, old api version John