mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Yi <yi.zhang@huaweicloud.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	tytso@mit.edu, jack@suse.com
Subject: Re: [PATCH 1/6] jbd2: remove unused h_jdata flag of handle
Date: Wed, 8 Jan 2025 10:39:52 +0800	[thread overview]
Message-ID: <5f302532-82fc-42af-b650-bd729be08fa2@huaweicloud.com> (raw)
In-Reply-To: <20241224202707.1530558-2-shikemeng@huaweicloud.com>

On 2024/12/25 4:27, Kemeng Shi wrote:
> Flag h_jdata is not used, just remove it.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@huawei.com>

> ---
>  include/linux/jbd2.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 50f7ea8714bf..c7fdb2b1b9a6 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -459,7 +459,6 @@ struct jbd2_revoke_table_s;
>   * @h_ref: Reference count on this handle.
>   * @h_err: Field for caller's use to track errors through large fs operations.
>   * @h_sync: Flag for sync-on-close.
> - * @h_jdata: Flag to force data journaling.
>   * @h_reserved: Flag for handle for reserved credits.
>   * @h_aborted: Flag indicating fatal error on handle.
>   * @h_type: For handle statistics.
> @@ -491,7 +490,6 @@ struct jbd2_journal_handle
>  
>  	/* Flags [no locking] */
>  	unsigned int	h_sync:		1;
> -	unsigned int	h_jdata:	1;
>  	unsigned int	h_reserved:	1;
>  	unsigned int	h_aborted:	1;
>  	unsigned int	h_type:		8;


  parent reply	other threads:[~2025-01-08  2:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24 20:27 [PATCH 0/6] Minor cleanups to jbd2 Kemeng Shi
2024-12-24 20:27 ` [PATCH 1/6] jbd2: remove unused h_jdata flag of handle Kemeng Shi
2025-01-03 14:35   ` Jan Kara
2025-01-08  2:39   ` Zhang Yi [this message]
2024-12-24 20:27 ` [PATCH 2/6] jbd2: remove unused return value of jbd2_journal_cancel_revoke Kemeng Shi
2025-01-03 14:37   ` Jan Kara
2025-01-08  2:43   ` Zhang Yi
2024-12-24 20:27 ` [PATCH 3/6] jbd2: remove unused return value of do_readahead Kemeng Shi
2025-01-03 14:39   ` Jan Kara
2025-01-08  2:46   ` Zhang Yi
2024-12-24 20:27 ` [PATCH 4/6] jbd2: remove stale comment of update_t_max_wait Kemeng Shi
2025-01-03 14:39   ` Jan Kara
2025-01-08  3:12   ` Zhang Yi
2024-12-24 20:27 ` [PATCH 5/6] jbd2: correct stale function name in comment Kemeng Shi
2025-01-03 14:36   ` Jan Kara
2025-01-08  3:22   ` Zhang Yi
2024-12-24 20:27 ` [PATCH 6/6] jbd2: Correct stale comment of release_buffer_page Kemeng Shi
2025-01-03 14:44   ` Jan Kara
2025-01-08  3:27   ` Zhang Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f302532-82fc-42af-b650-bd729be08fa2@huaweicloud.com \
    --to=yi.zhang@huaweicloud.com \
    --cc=jack@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shikemeng@huaweicloud.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®