From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: krzk@kernel.org
Cc: alim.akhtar@samsung.com, mst@redhat.com, javierm@redhat.com,
tzimmermann@suse.de, bartosz.golaszewski@linaro.org,
luzmaximilian@gmail.com, sudeep.holla@arm.com,
conor.dooley@microchip.com, bjorn@rivosinc.com,
ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, marcan@marcan.st,
neal@gompa.dev, alyssa@rosenzweig.io, broonie@kernel.org,
andre.draszik@linaro.org, willmcvicker@google.com,
peter.griffin@linaro.org, kernel-team@android.com,
vincent.guittot@linaro.org, daniel.lezcano@linaro.org,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v2 2/2] firmware: add exynos acpm driver
Date: Mon, 21 Oct 2024 15:52:26 +0100 [thread overview]
Message-ID: <5f31c010-a965-48f3-a975-efd8307316bb@linaro.org> (raw)
In-Reply-To: <20241017163649.3007062-3-tudor.ambarus@linaro.org>
On 10/17/24 5:36 PM, Tudor Ambarus wrote:
> +static int exynos_acpm_chans_init(struct exynos_acpm *exynos_acpm)
> +{
> + struct exynos_acpm_shmem_chan *shmem_chans, *shmem_chan;
> + struct exynos_acpm_shmem *shmem = exynos_acpm->shmem;
As Krzysztof has already noticed, I need to use the __iomem pointer
token when referring to shmem structures. This could be caught with
sparse as well, lesson learnt:
drivers/firmware/samsung/exynos-acpm.c:493:54: sparse: sparse:
incorrect type in argument 2 (different address spaces) @@ expected
void [noderef] __iomem *addr @@ got unsigned int * @@
The following changes will be needed for v3:
--- a/drivers/firmware/samsung/exynos-acpm.c
+++ b/drivers/firmware/samsung/exynos-acpm.c
@@ -161,7 +161,7 @@ struct exynos_acpm_chan {
* @num_chans: number of channels available for this controller.
*/
struct exynos_acpm {
- struct exynos_acpm_shmem *shmem;
+ struct exynos_acpm_shmem __iomem *shmem;
struct exynos_acpm_chan *chans;
void __iomem *sram_base;
void __iomem *regs;
@@ -485,8 +485,8 @@ static void __iomem *exynos_acpm_get_iomem_addr(void
__iomem *base,
}
static void exynos_acpm_rx_queue_init(struct exynos_acpm *exynos_acpm,
- struct exynos_acpm_shmem_chan
*shmem_chan,
- struct exynos_acpm_queue *rx)
+ struct exynos_acpm_shmem_chan __iomem *shmem_chan,
+ struct exynos_acpm_queue *rx)
{
void __iomem *base = exynos_acpm->sram_base;
@@ -496,8 +496,8 @@ static void exynos_acpm_rx_queue_init(struct
exynos_acpm *exynos_acpm,
}
static void exynos_acpm_tx_queue_init(struct exynos_acpm *exynos_acpm,
- struct exynos_acpm_shmem_chan
*shmem_chan,
- struct exynos_acpm_queue *tx)
+ struct exynos_acpm_shmem_chan __iomem *shmem_chan,
+ struct exynos_acpm_queue *tx)
{
void __iomem *base = exynos_acpm->sram_base;
@@ -527,8 +527,8 @@ static int exynos_acpm_alloc_cmds(struct exynos_acpm
*exynos_acpm,
static int exynos_acpm_chans_init(struct exynos_acpm *exynos_acpm)
{
- struct exynos_acpm_shmem_chan *shmem_chans, *shmem_chan;
- struct exynos_acpm_shmem *shmem = exynos_acpm->shmem;
+ struct exynos_acpm_shmem_chan __iomem *shmem_chans, *shmem_chan;
+ struct exynos_acpm_shmem __iomem *shmem = exynos_acpm->shmem;
struct mbox_chan *mbox_chan, *mbox_chans;
struct exynos_acpm_chan *chan, *chans;
struct device *dev = exynos_acpm->dev;
next prev parent reply other threads:[~2024-10-21 14:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 16:36 [PATCH v2 0/2] mailbox: add async request mechanism w/ a user Tudor Ambarus
2024-10-17 16:36 ` [PATCH v2 1/2] mailbox: add async request mechanism to empower controllers w/ hw queues Tudor Ambarus
2024-10-18 4:17 ` Jassi Brar
2024-10-18 7:49 ` Tudor Ambarus
2024-10-21 6:18 ` Tudor Ambarus
2024-10-21 16:32 ` Jassi Brar
2024-10-22 13:26 ` Tudor Ambarus
2024-10-24 1:27 ` Jassi Brar
2024-10-24 10:45 ` Tudor Ambarus
2024-10-29 15:59 ` Jassi Brar
2024-11-18 15:22 ` Tudor Ambarus
2024-10-17 16:36 ` [PATCH v2 2/2] firmware: add exynos acpm driver Tudor Ambarus
2024-10-21 11:52 ` Krzysztof Kozlowski
2024-10-21 14:12 ` Tudor Ambarus
2024-10-22 4:38 ` Krzysztof Kozlowski
2024-10-22 7:27 ` Vincent Guittot
2024-10-22 7:58 ` Tudor Ambarus
2024-10-23 9:00 ` Krzysztof Kozlowski
2024-10-23 9:53 ` Tudor Ambarus
2024-10-23 10:02 ` Tudor Ambarus
2024-10-24 9:36 ` Krzysztof Kozlowski
2024-10-25 10:00 ` Tudor Ambarus
2024-10-21 14:52 ` Tudor Ambarus [this message]
2024-10-21 16:47 ` Alim Akhtar
2024-10-25 9:44 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f31c010-a965-48f3-a975-efd8307316bb@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=alyssa@rosenzweig.io \
--cc=andre.draszik@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bjorn@rivosinc.com \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel.lezcano@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=javierm@redhat.com \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=marcan@marcan.st \
--cc=mst@redhat.com \
--cc=neal@gompa.dev \
--cc=peter.griffin@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®