From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6821DC433FE for ; Fri, 4 Nov 2022 14:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbiKDO3B (ORCPT ); Fri, 4 Nov 2022 10:29:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232272AbiKDO1J (ORCPT ); Fri, 4 Nov 2022 10:27:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B588F326F8; Fri, 4 Nov 2022 07:24:45 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id EFB7F660000F; Fri, 4 Nov 2022 14:24:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667571884; bh=lCeV9wSv7Wjh6wBQ7nZNRQQ2UebkmFaangKITJNioTQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZDCbn4bWhJwZ+8D2s6buAJCgF2biozJ2lVFOZxE7wv1Gr11dhpucJMeqcXo6hiZvd Bdif+XV/OmpQZwkroobUMCKWUIMf0iBqCr8GyatH4IXsWkeoilHAQikAwIfam/J9eq DD6/+VUU/3A9CJAaWoFlfeJ1yJs2ygYfccz0P/wf23cOD9Hi2UtPJc1QQY8woSU+fl b8VUfQvLwrxO83hF9dCpQ/MMYyD3vUlBq4ZSretRNOfKapRlKgzi2JraW14GlWAPSP LQ1EnFglz7BOZ5F7jsdW64CQfSPeDqBJvmT/zCZ8KwZSauZ1acPRWGhPXJ8idQfJxl W1v6LjU/AoPXA== Message-ID: <5f3783a1-5e70-394d-1218-5969fb08c9c8@collabora.com> Date: Fri, 4 Nov 2022 15:24:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver To: Krzysztof Kozlowski , agross@kernel.org Cc: andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marijn.suijten@somainline.org, kernel@collabora.com, AngeloGioacchino Del Regno References: <20221104133506.131316-1-angelogioacchino.delregno@collabora.com> <20221104133506.131316-3-angelogioacchino.delregno@collabora.com> <3af810a7-0490-da36-f263-e74cd3553c84@collabora.com> <18f5bcaa-2a41-b2b0-44a2-273728c52cfb@linaro.org> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <18f5bcaa-2a41-b2b0-44a2-273728c52cfb@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/11/22 15:22, Krzysztof Kozlowski ha scritto: > On 04/11/2022 10:18, AngeloGioacchino Del Regno wrote: >> Il 04/11/22 15:04, Krzysztof Kozlowski ha scritto: >>> On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote: >>>> From: AngeloGioacchino Del Regno >>>> >>>> The Ramp Controller is used to program the sequence ID for pulse >>>> swallowing, enable sequence and linking sequence IDs for the CPU >>>> cores on some Qualcomm SoCs. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> --- >>>> drivers/soc/qcom/Kconfig | 9 + >>>> drivers/soc/qcom/Makefile | 1 + >>>> drivers/soc/qcom/ramp_controller.c | 330 +++++++++++++++++++++++++++++ >>>> 3 files changed, 340 insertions(+) >>>> create mode 100644 drivers/soc/qcom/ramp_controller.c >>>> >>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig >>>> index 024e420f1bb7..1e681f98bad4 100644 >>>> --- a/drivers/soc/qcom/Kconfig >>>> +++ b/drivers/soc/qcom/Kconfig >>>> @@ -95,6 +95,15 @@ config QCOM_QMI_HELPERS >>>> tristate >>>> depends on NET >>>> >>>> +config QCOM_RAMP_CTRL >>>> + tristate "Qualcomm Ramp Controller driver" >>>> + depends on ARCH_QCOM >>> >>> I propose: >>> depends on ARCH_QCOM && ARM || COMPILE_TEST >>> >>> I don't think it is used on ARM64 SoCs, so let's make life of distros >>> easier. >> >> Forgot to reply to this one: MSM8956 and MSM8976 are ARM64 SoCs :-) > > Yeah, indeed, I meant the other way around, so && ARM&64 :) > I went too fast and sent out a v2 with ARCH_QCOM || COMPILE_TEST.... ....should I go for a v3? Cheers, Angelo