From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E36B310E5 for ; Thu, 15 May 2025 00:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747268078; cv=none; b=ARxDIW1836wM/LvFkEmOEmM8yYBG1a3paRA3uHGLBfUFBmPLL4jutzML8Fuw5R4X7iT/9Jpsu/EPakLNs0/dekghJO96SDmk/SgEbxz8noIdf044UCuerwozakntpJfsUa7xer70aiZe84O86q2rXKzlHjNK6besotzj3xU7RNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747268078; c=relaxed/simple; bh=quYQ44lNL28NGsGxFsC3r6wlm1Y7jznRiSlxIni8Rlc=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=dtoTJB8t9XTX+pNNMlKnMJuDtkaVMxv+egKDkhLi8qTVzqpzf+ZK1g+7FrDCflt5mzTueHT2qyYw9sH4lOAP2+3wgYjZGZ818F5K23/WUKMqj6lUrHUjK1f9A+NJXx40Jtiem1rgISct26YXKIr7m7G5cIByn4FeNMa7HQcmsoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GWzvy9QZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GWzvy9QZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747268075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNzHUEUeO2dhjTSVzvgUR5Z+U81BlGK7DOEGqJYrY1c=; b=GWzvy9QZP3x91pnIqzyaVJKM/mJN9KH5e7aSTT3Glh2060RDLgQlWlUAIqRhK/l8PCWz74 3IlILGOqGxtrQ9S5ibfvcMG6Tx9DRavI/l1HlQXGNSAGMxijpUQqKIGskxNd86MJR7xT7h NH93idXfRD43YT3tbHQtVe5t2hMD0NY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-VhQx-Ln-Po-lgcW8Xy5ung-1; Wed, 14 May 2025 20:14:34 -0400 X-MC-Unique: VhQx-Ln-Po-lgcW8Xy5ung-1 X-Mimecast-MFC-AGG-ID: VhQx-Ln-Po-lgcW8Xy5ung_1747268073 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6f617f20b2bso8279236d6.1 for ; Wed, 14 May 2025 17:14:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747268073; x=1747872873; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kNzHUEUeO2dhjTSVzvgUR5Z+U81BlGK7DOEGqJYrY1c=; b=kr/ikuOSaNCYM1C6LHjwVbUFLM+xQH7L6odUtgzADmc3nuWbTope/aLmzP767xrUcy 7N1GjqaPwvQkoVes4kVQDr0Hb5yBUKCiFu+9FNFII2Q25iqAUSiVPSgolKIcHDpjjyhU Ccr11HgkSIPBbGEbrK9EVR912ngc0mfbej3HfRqbIqPavKGApP3nip21nPJ9u0o5LQB7 gpAx0YZmTRP/b29yEEqOLCD6Vtc6DZEwnnJL6y4G2+VrXulNJTlrNRm6XxTaEKivoWK/ rXpC7hwlBkxDbHH+lqvJXKX9Jeca1DOeO+w0cvjVPavYTOZCG0XB0eUEzOcpX1iVw23h Sgxg== X-Forwarded-Encrypted: i=1; AJvYcCUQ2TxaZJZrr55Az9SqLwBn8M2IJ7YZZbVxp6GvtWXRwAF2Eo7QeNDQDmJG8Z96uA48DnEmAj8L2PpdeE4=@vger.kernel.org X-Gm-Message-State: AOJu0YwSs3a90Wr6EbdqRSzP86xg3bQObcYGE2ig4g+nFuYGeEHWeZ5F n2n4P2tl98fVL1k45K9iRxH1NoOQJnRsu5sdrXgWciJ/cmpZt396sghFWvdHgUUnQLPdkKqmOLd poSIW9t/yA3FOFi4IYh7ll66aeiWqOmySCxvkxL1mQ30YSvVTu2gWO5b7qD9ZkQ== X-Gm-Gg: ASbGncs5oma6AXQ3mWtp43/Ohphbc9PFlypnToUJjKTNLa9wPX5sKmUnpiPAK4d8Sc3 Ma+EYNWHuZm7G6a+sfYZ046knKCtZ6AqLesL200lOPGx+5RAQI7cwaa0nTJEoukf+wQyEReLMMO UebMKS+paY0oGhKyXT9bwyjZCWBsA64p1IMWURFr0+RYcAQCcJ6rHpYKo8fTMRZaMScKZsrtOQi UehP6oyTQjlruJZ5xfXibnaGAgvxxfzs6YuvJLyJEPf3CU1RwmWFopB6xVHJy3ORzdccKxg9tc0 W0YJT1MNCqQmL3Aj87oyycvA2vmbyruTBhwvAUqzbOPzklliEOiS8yRuNg== X-Received: by 2002:a05:6214:d0c:b0:6e8:fe16:4d44 with SMTP id 6a1803df08f44-6f896ea9057mr99475066d6.31.1747268072576; Wed, 14 May 2025 17:14:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsr7IFrS3iOvG8LAJsmK3Z9rLV7eHpX1e12kq9yRd9jWKqc02gH6HkR1aDUM2ojcwgcm4bmg== X-Received: by 2002:a05:6214:d0c:b0:6e8:fe16:4d44 with SMTP id 6a1803df08f44-6f896ea9057mr99474556d6.31.1747268072185; Wed, 14 May 2025 17:14:32 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f6e39e0c8csm87119136d6.18.2025.05.14.17.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 17:14:31 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <5f412ff9-c6a3-4eb1-9c02-44d7c493327d@redhat.com> Date: Wed, 14 May 2025 20:14:26 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 01/43] llist: move llist_{head,node} definition to types.h To: Byungchul Park , linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com References: <20250513100730.12664-1-byungchul@sk.com> <20250513100730.12664-2-byungchul@sk.com> Content-Language: en-US In-Reply-To: <20250513100730.12664-2-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/13/25 6:06 AM, Byungchul Park wrote: > llist_head and llist_node can be used by very primitives. For example, I suppose you mean "every primitives". Right? However, the term "primitive" may sound strange. Maybe just saying that it is used by some other header files. Cheers, Longman > dept for tracking dependencies uses llist in its header. To avoid header > dependency, move those to types.h. > > Signed-off-by: Byungchul Park > --- > include/linux/llist.h | 8 -------- > include/linux/types.h | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/linux/llist.h b/include/linux/llist.h > index 2c982ff7475a..3ac071857612 100644 > --- a/include/linux/llist.h > +++ b/include/linux/llist.h > @@ -53,14 +53,6 @@ > #include > #include > > -struct llist_head { > - struct llist_node *first; > -}; > - > -struct llist_node { > - struct llist_node *next; > -}; > - > #define LLIST_HEAD_INIT(name) { NULL } > #define LLIST_HEAD(name) struct llist_head name = LLIST_HEAD_INIT(name) > > diff --git a/include/linux/types.h b/include/linux/types.h > index 49b79c8bb1a9..c727cc2249e8 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -204,6 +204,14 @@ struct hlist_node { > struct hlist_node *next, **pprev; > }; > > +struct llist_head { > + struct llist_node *first; > +}; > + > +struct llist_node { > + struct llist_node *next; > +}; > + > struct ustat { > __kernel_daddr_t f_tfree; > #ifdef CONFIG_ARCH_32BIT_USTAT_F_TINODE