From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7273806C1 for ; Tue, 10 Mar 2026 10:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139724; cv=none; b=CLdr9MfAGiOBwurU3aG1nk1uolASBppOd1PRsS2oXkpq/jXVCf6LwBJDQ5pgx1eojBaMiMgVB8mGQ5RhdjKizBurlQI0ngcha6aOZ4X3QjohSpnfgjrVgotsV2VKlk19tRcQ+eCV8ZiF+wIusjJs53KCDlxsA8PDkQ2p0+migNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773139724; c=relaxed/simple; bh=9y3vAnjP3UtwfjC7j3GU01y6De/z672X2VvVuImLkRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JxnsYG+Qo2P4F1o+LNQbP+EPXZQ8FqGoFuVWrBkuoDo9Gm99jEi2M21e1arXVJINPKEa+/OEgV+D03FKAC40wNhTMN/wN3ZBqgfO8a8pfrNdzVXwRGJiYB+02xsREgifNEnqpyAcGidTnrpIovC6y982ZFzzjUv06bm/AXSVEqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cmhGZMy1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TNrL3yCp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cmhGZMy1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TNrL3yCp" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A9BKP93754878 for ; Tue, 10 Mar 2026 10:48:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5BUr7hXhaCbtwBIPXp9T/qypWoIvJOLLwsRBQ1CEOlg=; b=cmhGZMy10GIGbRim PXqjeP8UIPyvLxExQ2QNuY694zSycjQT/ML+bxRnn9ButtcRMZAfyj3lhVjTFEvu JLZUEOC/ICBV8qFcZ4MGImth+eh05gt1yC0mczwvucoK7TNLghJcPvFkKY1v8nbj nLHiOcVdLTSzLSTevmjc5sTm5DZqX61q7wyePf8ZfoOwVifcUw0Meftl1K0yVUb5 ePcEFZ5Q8Vdf4x8GmsgqCl+o/SBqLe9VE77aWJiudoF/2hAWgFtxoWmmGDpOCzpN j9oRmTnDd5NskAHPAzzGccKJz7UvdTXuPW6yfk63IEU0Y43j6DodFuTota3TApda kYwZZg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct477jtm5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 10:48:42 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd8dc8b434so121742385a.3 for ; Tue, 10 Mar 2026 03:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773139722; x=1773744522; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5BUr7hXhaCbtwBIPXp9T/qypWoIvJOLLwsRBQ1CEOlg=; b=TNrL3yCpeRuZeMW3AbFt867cfvwz0q1nMdGTKtoA8olT8a9RaqReRY/zz9RKHmtK27 c/xZ52+78dPERYSPg/M5J8JwOoMwfJpzcyhRLS+503OoCXvjRBOTNhRkSuh+xvUB1YwU e+lb6D4Mg6WO3fisVTqZyHwxe3cPwJDmPyBALtt+rkAUwZKo7auNLLeecuPNAqNZPBYt yYYQmku2qWFy3Q3VtuLP9iSKGx3K8pQ4yG34yj4KVdLUcVkpOdgDGp6fRW2oRibaZa/H tlqfpZV3leQC4y8Scs/60GoT9wmlLerrFYm4IevU+jS0mEXl7dfsnGWqlij6s34flWBt 9Acw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773139722; x=1773744522; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5BUr7hXhaCbtwBIPXp9T/qypWoIvJOLLwsRBQ1CEOlg=; b=N8JzZTTQ6FthmB9+XwCYBMZvdQ85z8cIO69c/s5CUkMcYMgHFawq7QE79iIQX+FqXW 6mWVQUoE9JR05SJ6mil1u/jbTBaa1uTyxejLhKOCok8CTiAFqBMjWs5dyd/3mmiIYc9P I3Hior8QHyuEk7xOtUiC6u4478IQj0Y0tA/TS0vHP3YqwjEkHT0Zg7atNiH8uNddLBFz o8C7MDdwI5aKII/BrGBlj+ZEEzy9Ff9Evg+A3zjQyHwJMHX3mWFB1O//AoFaFdgPYPZs PYY7m2fbcQz6kwO7e5HQwt5EUtfldBc2cs+cdrAfrOzH2YlhDI1mTg9Wh0sNBjqljcnB qMFw== X-Forwarded-Encrypted: i=1; AJvYcCX2bYQYVKK33SzR1WeKVK06EQKrAmz7MlyBDkUYmuTedwBsqSGVCsrq/x61K1JHmWUarchaYvTJxMCm88U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6aveccZGyULb6nu8QQiHJQmuPZfmvSvibCWxyDpLUDMOepJC6 0IzyW097S22h/xYSNM+UZ1/4G9ej/XKMJolywMPaeOkLMKirYpoC4kW8zfTfgpvkr+CxWn3XFdF Uwq7iey7dRmh3Z47bracDSg4z9a5bdAhlLO7CTdvuK9nPC8BAbEbpoCzNBbQpVAD4oNw= X-Gm-Gg: ATEYQzy6AsjHHwfXJxwkL1n0Jxjxi5YYVCb4cXXMCzeZ5RdhLIBqtqYkcQ6aKzuBNMN cXtSefYQSNycQQuyvRiuVXTG/cYy40+1U3i73vIEgU6FnCkZnabsuvTYRx2fC5CfqGEeQzP+LOK wI0leMj2r2nQlCagzhLRCu3b9fSsGzkWjk+NiOH0ynmWIKnKvkxIo4iIVtr+FmEpowhQakED90c b0vfPluvyRKVBz7TvAf7Y4darddqgNg4uE78sEA0XwYLkuuha6c93yddzILf6nEpXCJjaw3OTgU zBCp1wjLRNEDLDLLaY2JccprcHapubKBgXY4dh39NKra7+MySqQzdBVNzPg4yEwq0NMlbunXGcB rb2N34ok6nXy5OVB6BFlkoP6t2tOLjEDY1TaNjKYGvT9/0fCEFUiMernRXUVkM5o+dyErw6Iwe6 px3F8= X-Received: by 2002:a05:620a:370d:b0:8c7:1aea:53b7 with SMTP id af79cd13be357-8cd6d49009amr1450051885a.9.1773139721796; Tue, 10 Mar 2026 03:48:41 -0700 (PDT) X-Received: by 2002:a05:620a:370d:b0:8c7:1aea:53b7 with SMTP id af79cd13be357-8cd6d49009amr1450049585a.9.1773139721332; Tue, 10 Mar 2026 03:48:41 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f15c40esm494024166b.46.2026.03.10.03.48.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 03:48:40 -0700 (PDT) Message-ID: <5f41efde-3bbf-4832-bc46-1e83126301ce@oss.qualcomm.com> Date: Tue, 10 Mar 2026 11:48:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309-glymur-dts-crd-enable-kbd-tp-ts-v1-1-56e03f769a76@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260309-glymur-dts-crd-enable-kbd-tp-ts-v1-1-56e03f769a76@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA5MyBTYWx0ZWRfX8KPinSN/XFQM VOqI1t3NSyWWB5s1uy6tP8+/ODL0pzSXsnDtz88oupb5GQxSLE7OuUPk3Bcy0MZxfokfVBxLTxA i/12BeC1Wi2H3bqJ/SvSKFkzcLFUqyz2meLxnAoRuWh5Qpr/rwTWW1gDbWd+LzAjL+h0yak+2VO Hom+i7Nd0HFG7sxDgmU2JH8ILEUgsxG3JobSjzFlcX7TolO2WvV+kUDRjgUYtIKWRp8C/KzDzu/ L9R+9Ql0UZtGUFaU+brW8SnxEbnLxsV8XAMbJonDPG+UqY5HWF8Z3MtN0WWhMVXXOmuFiVdFuSO bFwv8ETZYzvl5PY/4pbc2pPcXTtpVyq+NF1gCwf1iIZXQO58K/AjEcwZKkj5HqWYJTJLMpBcN4K mQvow1+WbYrVOht4ljiuzBvX6/ISYfSf5qtowYKJ/VAPuOCc0gfNaPnetkscystWPnBUvnld3cc s31xhfNtQhbW1CSwyrg== X-Proofpoint-GUID: 7u9MNgIyyBmnLEniZJZSC1Cw_UoOCt0n X-Authority-Analysis: v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69aff70a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=bX_bX3K2iqdTeITeXfoA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 7u9MNgIyyBmnLEniZJZSC1Cw_UoOCt0n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100093 On 3/9/26 5:35 PM, Abel Vesa wrote: > On CRD, the keyboard, trackpad and touchscreen are connected over I2C > and all share a 3.3V regulator. > > So describe the regulator and each input device along with their > pinctrl states. > > Signed-off-by: Abel Vesa > --- [...] > + vreg_misc_3p3: regulator-misc-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_MISC_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&pmh0110_f_e0_gpios 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&misc_3p3_reg_en>; property-n property-names please [...] > base-commit: 5138081b838d92e1bfcddc7b72b9215cca6e83f0 > change-id: 20260309-glymur-dts-crd-enable-kbd-tp-ts-c80c0cb78940 > prerequisite-change-id: 20260109-dts-qcom-glymur-add-usb-support-617b6d9d032c:v4 > prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 > prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 > prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 > prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f > prerequisite-change-id: 20260109-dts-qcom-glymur-crd-add-edp-03f0adde9750:v4 > prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 > prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 > prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 > prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f > prerequisite-patch-id: 6a291fd702870ca28d64439313d498593996b741 > prerequisite-patch-id: c96958ab5c5605fb9577645ac5bfe5912cdfebfe > prerequisite-patch-id: bfa283218723a48e54fcd842484b004c877339b7 > prerequisite-patch-id: 346f2db0933c551a039f63b945f989a5c8320657 > prerequisite-patch-id: 919020405b70d588fa4356a5cbfb44e67006102e More importantly, are they all actual dependencies? Konrad