From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbdJPESc (ORCPT ); Mon, 16 Oct 2017 00:18:32 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47978 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbdJPESa (ORCPT ); Mon, 16 Oct 2017 00:18:30 -0400 Subject: Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain To: Arnaldo Carvalho de Melo , Milian Wolff Cc: Jiri Olsa , Jin Yao , Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Namhyung Kim , Peter Zijlstra , ravi.bangoria@linux.vnet.ibm.com References: <20171009203310.17362-1-milian.wolff@kdab.com> <20171009203310.17362-12-milian.wolff@kdab.com> <20171013133903.GN3503@kernel.org> <20171013140834.GO3503@kernel.org> From: ravi Date: Mon, 16 Oct 2017 09:48:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013140834.GO3503@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-MML: disable x-cbid: 17101604-0008-0000-0000-000004A019A8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101604-0009-0000-0000-00001E324678 Message-Id: <5f4372e7-8e75-bf34-3947-4b38036241a4@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160059 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 October 2017 07:38 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 13, 2017 at 10:39:03AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: >>> Some of the code paths I introduced before returned too early >>> without running the code to handle a node's branch count. >>> By refactoring match_chain to only have one exit point, this >>> can be remedied. >> Fixing up this one now. > Millian, this is all fresher in your mind, can you please take a look at > my perf/core branch and check if the change i made to ]PATCH v5 09/16] > "perf report: compare symbol name for inlined frames when matching" is > ok wrt Ravi's fix and then, please, rebase v5 on top of what is there? > > Ravi, please take a look at this as well, to see if with these changes > your fix remains valid, ok? Yes Arnaldo, my changes are still valid. Milian, Can you please change this patch such that it incorporates dso comparison for CCKEY_FUNCTION. ( Also, will that be good to change macro to CCKEY_FUNCTION_DOS ?) Thanks, Ravi