From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759870AbdJQSY1 (ORCPT ); Tue, 17 Oct 2017 14:24:27 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41856 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759828AbdJQSYZ (ORCPT ); Tue, 17 Oct 2017 14:24:25 -0400 Subject: Re: [RFC PATCH 3/3] mm/map_contig: Add mmap(MAP_CONTIG) support To: Guy Shattah , Michal Nazarewicz , Michal Hocko Cc: Christopher Lameter , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , Marek Szyprowski , "Aneesh Kumar K . V" , Joonsoo Kim , Anshuman Khandual , Laura Abbott , Vlastimil Babka References: <20171013084054.me3kxhgbxzgm2lpr@dhcp22.suse.cz> <20171013152801.nbpk6nluotgbmfrs@dhcp22.suse.cz> <20171013154747.2jv7rtfqyyagiodn@dhcp22.suse.cz> <20171013161736.htumyr4cskfrjq64@dhcp22.suse.cz> <752b49eb-55c6-5a34-ab41-6e91dd93ea70@mellanox.com> <20171016082456.no6ux63uy2rmj4fe@dhcp22.suse.cz> <0e238c56-c59d-f648-95fc-c8cb56c3652e@mellanox.com> <20171016123248.csntl6luxgafst6q@dhcp22.suse.cz> From: Mike Kravetz Message-ID: <5f48b8a3-f187-0645-4b7d-3643129daf41@oracle.com> Date: Tue, 17 Oct 2017 11:23:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 07:20 AM, Guy Shattah wrote: > > >> On Tue, Oct 17 2017, Guy Shattah wrote: >>> Are you going to be OK with kernel API which implements contiguous >>> memory allocation? Possibly with mmap style? Many drivers could >>> utilize it instead of having their own weird and possibly non-standard >>> way to allocate contiguous memory. Such API won't be available for >>> user space. >> >> What you describe sounds like CMA. It may be far from perfect but it’s there >> already and drivers which need contiguous memory can allocate it. >> > > 1. CMA has to preconfigured. We're suggesting mechanism that works 'out of the box' > 2. Due to the pre-allocation techniques CMA imposes limitation on maximum > allocated memory. RDMA users often require 1Gb or more, sometimes more. > 3. CMA reserves memory in advance, our suggestion is using existing kernel memory > mechanisms (THP for example) to allocate memory. I would not totally rule out the use of CMA. I like the way that it reserves memory, but does not prohibit use by others. In addition, there can be device (or purpose) specific reservations. However, since reservations need to happen quite early it is often done on the kernel command line. IMO, this should be avoided if possible. There are interfaces for arch specific code to make reservations. I do not know the system initialization sequence well enough to know if it would be possible for driver code to make CMA reservations. But, it looks doubtful. -- Mike Kravetz