mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kailang <kailang@realtek.com>
To: Jian-Hong Pan <jian-hong@endlessm.com>, Takashi Iwai <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@endlessm.com" <linux@endlessm.com>,
	Daniel Drake <drake@endlessm.com>
Subject: RE: [PATCH 2/3] ALSA: hda/realtek: Enable headset mic of Acer C20-820 with ALC269VC
Date: Fri, 3 Jul 2020 07:09:44 +0000	[thread overview]
Message-ID: <5f49308c3090463791abddb12e12258b@realtek.com> (raw)
In-Reply-To: <20200703070512.174394-2-jian-hong@endlessm.com>

Please also link model ALC269_FIXUP_HEADSET_MODE on this.

> -----Original Message-----
> From: Jian-Hong Pan <jian-hong@endlessm.com>
> Sent: Friday, July 3, 2020 3:05 PM
> To: Takashi Iwai <tiwai@suse.com>
> Cc: Kailang <kailang@realtek.com>; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan
> <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com>
> Subject: [PATCH 2/3] ALSA: hda/realtek: Enable headset mic of Acer C20-820
> with ALC269VC
> 
> The Acer Aspire C20-820 AIO's audio (1025:1065) with ALC269VC can't detect
> the headset microphone until ALC269VC_FIXUP_ACER_HEADSET_MIC quirk
> maps the NID 0x18 as the headset mic pin.
> 
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
>  sound/pci/hda/patch_realtek.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index dfb4bca07d3f..3255da8b3849 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6150,6 +6150,7 @@ enum {
>  	ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,
>  	ALC295_FIXUP_ASUS_MIC_NO_PRESENCE,
>  	ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS,
> +	ALC269VC_FIXUP_ACER_HEADSET_MIC,
>  };
> 
>  static const struct hda_fixup alc269_fixups[] = { @@ -7339,6 +7340,15 @@
> static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HEADSET_MODE
>  	},
> +	[ALC269VC_FIXUP_ACER_HEADSET_MIC] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x18, 0x02a11030 }, /* use as headset mic */
> +			{ }
> +		},
> +		.chained = true,
> +		.chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
> +	},
>  };
> 
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7354,6 +7364,7
> @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1025, 0x0775, "Acer Aspire E1-572",
> ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572),
>  	SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G",
> ALC282_FIXUP_ASPIRE_V5_PINS),
>  	SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860",
> ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
> +	SND_PCI_QUIRK(0x1025, 0x1065, "Acer Aspire C20-820",
> +ALC269VC_FIXUP_ACER_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14",
> ALC283_FIXUP_CHROME_BOOK),
>  	SND_PCI_QUIRK(0x1025, 0x1099, "Acer Aspire E5-523G",
> ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1025, 0x110e, "Acer Aspire ES1-432",
> ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
> --
> 2.27.0


  reply	other threads:[~2020-07-03  7:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03  7:05 [PATCH 1/3] ALSA: hda/realtek - Enable audio jacks of Acer vCopperbox " Jian-Hong Pan
2020-07-03  7:05 ` [PATCH 2/3] ALSA: hda/realtek: Enable headset mic of Acer C20-820 " Jian-Hong Pan
2020-07-03  7:09   ` Kailang [this message]
2020-07-03  7:05 ` [PATCH 3/3] ALSA: hda/realtek: Enable headset mic of Acer Veriton N4660G " Jian-Hong Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f49308c3090463791abddb12e12258b@realtek.com \
    --to=kailang@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=drake@endlessm.com \
    --cc=jian-hong@endlessm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®