From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdIOHt5 (ORCPT ); Fri, 15 Sep 2017 03:49:57 -0400 Received: from mail-cys01nam02on0084.outbound.protection.outlook.com ([104.47.37.84]:52895 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750787AbdIOHty (ORCPT ); Fri, 15 Sep 2017 03:49:54 -0400 Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register. To: Andrew Lunn , Fahad Kunnathadi CC: , , , , , References: <1505373391-18697-1-git-send-email-fahad.kunnathadi@dexceldesigns.com> <20170914143454.GB27601@lunn.ch> From: Michal Simek Message-ID: <5f4bd003-d251-5a14-497a-9cc72dd0f160@xilinx.com> Date: Fri, 15 Sep 2017 09:49:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170914143454.GB27601@lunn.ch> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23330.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(2980300002)(438002)(199003)(189002)(24454002)(31686004)(106466001)(230700001)(229853002)(36756003)(305945005)(5660300001)(6246003)(83506001)(9786002)(356003)(23676002)(2906002)(50466002)(6666003)(58126008)(54906002)(63266004)(316002)(65956001)(8936002)(86362001)(77096006)(65806001)(4326008)(39060400002)(31696002)(53546010)(478600001)(64126003)(65826007)(2950100002)(33646002)(81166006)(54356999)(50986999)(76176999)(189998001)(81156014)(8676002)(47776003)(36386004)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1936;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT014;1:30e8+fnotxpvvThXMKHvvSdAYvYhs6yYltBJ+tW4uY5FkHkj1DZe+Lc0O8ytGm0aMe/laY6lIuDx/WyGTHLR15dbx/58zE9hXTBlYkYSeEhntOld9a4qWg6mVAzOG/7l X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34edbd98-d1f7-4ff0-9af1-08d4fc0e5799 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:SN1PR0201MB1936; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;3:H0qkh46rY/uidGz88GBobFy0ZL89Na8xm5QqRvAOwK1umpXfxUvbzEj8u4SWOhiR3NUaBW+yJlI4MwEnLisJSV5TrjnnSaBB0jV0l0oPBONyEBnq5U4udkov37odSTRSU8pD6proCNn1C55vQUHj9Q8tKZYiLDG01KspyeCz2W3m00EYUTtY2mtmhYKFaAFgBUcMYkJAm1GzTAj9o6ovkfvGiZcji+377VqJ91xT09uvIl/19rlvqhDVfy8pl2No2s24iewS684KkCLSrsqUOWV0FTQYusPi2+1/a2lo9oslGETzMLT04aaNzInupnOU+06pz1qQxREuSGA6mF0lT1YM7hZQrmwWwZ+Ue1EBHTU=;25:h3QdTxNn9RpBjdCeEPc8sIwfeD3N+mzB7pHwyEHDlMBLj+rxUBKPVt3oX6WBN12qwgzAfCgx0+6060ahBwgFt+cSKjwoFTOh61PaEljfRLnHpw3DibvyP82LLUT2zNgToYW0lsbz4s9mAq+yKRF8A10jo/Cf6GiunK2ZWgpguXWFoOiDWqdaE4CdBlKUDvTb5lIxBx+5FQEIDbRjCsMQPwzmqWqi7NAOv4Q6BVO8J6nvnLMhFO/LUuKU89Rgfo0wLU/qQklcGeqmYSOLKkktSw0s6RGuvT433dM7YCKoo3Ll7Nh7Q/7Lk8IqcSl3WtZLIJPXzDpENwAqRCDppu1YPA== X-MS-TrafficTypeDiagnostic: SN1PR0201MB1936: X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;31:EdeJuE/8mOjt0qO8A0zH1JjsZkRYVdcherhqCzflZJmB9TiwTJcrNwGVSYqYY5I8cixRI2QMcRBjnQeffvDZNnbXKQeMc+01SVbJ7S3uZGpRSoQGYef1BkCWZD7iJ2cVza1mfvBoFa9o7yORHPnPua5GSbaOBk9ikMEjsojiTVA330tEjqrU3XyBYQ9K7l6CoUw9y/mG/VjpXtfLeN61P1vuEFeZhCcwZPLlxz6EF/4=;20:qUm1r49boGF35RfS6oKatuY8I9xLAexO4g2Me0CsBxvTnA4iSoIaJt0XAWmZdJBJujnAYJHJu31NrtLlPXlGDSd91Cmw8+ZXVspJBO+1Fezt8yp+RjwZEVSk3flRG+id13/6kUvLV1VwvSmU0aHKqE+BO93C0atoApyo7eaGB5AlJRrBESpJ/sXZsDsE621dKRigafb9G7yzrp+YZLml7gCJsql3tXtGDRP+pZKqYq5xK8Bn0/5TbtKvDbRpBbOauWA+fxKkT63msao4JpaG0tCOEHjpxoWayim/zZN86pWbxex25io5aNnrSh9DPLF8cQWB8QZ1SJE7pUAdDa04WXRG2tEKqSgBHxR8/nqPfbsuYsyzhvMOgP/DKpVPnTKvXPu3tm7oYvAwqOEk0tC/9hbddI/gQ+fTHwvGih8+1ad9GfJG9YLIEt53DungrLSDTd4ZohTn0wSNpGURp8p/0mOCJWrNG2epsnC25E7L2tx2A2Bi9WCRC6NNh3QD+zdo X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR0201MB1936;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR0201MB1936; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;4:+rWzWW0FVMxolnk31t2nzY0rY8Y1Cbjot2+bIItMqJm8MPM9EWGMl5Ds09c0sScEF4v+gR7OoeCShxwJYM3uJoP+IOfLkjuVEhTEO4wTevmWDn5TvsY4B/yf5ZU1g4/zw82Wyb4U4LMAHybYtrGKW0wTfqu32glzVHhBzTamPziihDdGbCA2QOEMF3+YJSW+DCRUEZyYo5ov9nrXiEsGiDkJymfFMmQdSs712LAOl0p8Kc3hNkSC051pQvnd9nQA X-Forefront-PRVS: 0431F981D8 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAyMDFNQjE5MzY7MjM6N3lPTldudUlJR200UGVVWE9KbG9DK28v?= =?utf-8?B?TmRweVpJUVlNZlhSTFpzNkxPbXNIOW53ckVxV2V3YmdnN2o1RkxKWGpsb0lP?= =?utf-8?B?Qys2STJOMGJKL1h6M0tuYXRWZWlsdTFIU0NTaXMwSXVLOXdxRTJPZ0o1cG05?= =?utf-8?B?RGRhV3hvK0szVTNUb1JTM1VBZmVYaXlwVG1Hb3ltSzNROWN2aWJ0OFZNaHZX?= =?utf-8?B?SGZseFBWWi9sOU1GVi9wNEF6emYrWHpnWUdUSE5rRzgxN2QrRC9kai9jRWMw?= =?utf-8?B?S2JrUGs5SGFIQVo0SGozRThmUEc2Ump2T0VLaWprRmplUjJEeFVTSjluMk1Z?= =?utf-8?B?Yk1LRjFOa2R2aU9pcmNEVS9qUm13RHlzcTdFYjlLWG9xSlQxaXhNdkxQUE0v?= =?utf-8?B?VERLeE1MQ1NiY0FoZHo1L2tGaitpb0p0ZjQwS0VrNm1SK1hSbUxwaHo1ZlUr?= =?utf-8?B?M3RlSVhxL04rQTJJME9GQjJ0R0VsQkVkRUdDYlFXRVlkQnlNdWpCK1FNZzhD?= =?utf-8?B?MnZhbGx4amYrbGlOeTdja1VKSTRVOW9scmI2NlR0czNnZ0g0d1NCL01xTlgr?= =?utf-8?B?OWZBc09lblpEYzV1Tjh0ZFhlbkU0OVYxOWxrZkNvMU9VQzF1aUFzcXpZN01l?= =?utf-8?B?eDRLWHEvVG1rSzdaQmxObXN2ZC9uaDFBbkUzVE83UWRNRDdBRFRscDRFRklG?= =?utf-8?B?eXZGOHFZcUhqUGpvWTRFd1hlVU9SQjZCU29oVW4rZWNMcVJFNXBsaitkbW1t?= =?utf-8?B?ZklTa3B1bnJIS3V1SE9VRXFqWXdBbGc2c0tnMkFUMHV0YzB4MDN0UWE1cmFt?= =?utf-8?B?U29oeWljSUpyWU1jRElxNHBhWlN1WUxwRUNOUlB1MFJieTl3c3hZK2h5NlVU?= =?utf-8?B?UElGRStnNnhobmorOEVQOFd5bzFJN1dqcHlMMTM5MHpZVWVOTmJ4L28yR1Zx?= =?utf-8?B?czBOVXE3cWZORDZxVDhKQWx0bjNHaUxkRFptSUtUWVFHTDNnZ2pUdTNoYXl1?= =?utf-8?B?NFdCblcwdFRLT01QQi80YjVsM0ppODZHbFhmb1N3SjdYWHFEeVNsNk1telAy?= =?utf-8?B?Zy9qVVRmbTVWMURyM3UxRU9hNyttRCtZMC9scE13eU9LckdGY01xMDlMUUc5?= =?utf-8?B?RTE0WGs5N1htbG1EL1dicHBmSkFnSzJyeldWQUhoM1k1VzFLbTBKamJhMFo0?= =?utf-8?B?YTZIcnZmN21UYlZKaXRNUEdjUGtjVTlvL3dlODliZGE3aDhKU25jdDB0ZU9x?= =?utf-8?B?YWthTzVyMFBiK3BJZDlURE8wRnRkcWwxZ0NvUUlJZDRUNG9wYkVHQWRiakRQ?= =?utf-8?B?dmoveGZUdW9sb3lGbytjTkdBZW5qNWpPbkRMTGd6TW5hVlA3a0duRkNVcUtX?= =?utf-8?B?V1ZTSFpiT0VVQzljVlQ1ZHBRU3p3azRCM25YNlQ3VU1XbkhkVzNEU0RPRnJw?= =?utf-8?B?M1E5Z1BDZGRKdWJ6WjFBTmJCME1sQ0ZXRkg3ZU9sRkNLY2VDdzFSOEFnYnVL?= =?utf-8?B?eXZRUEVHQ01LNUFNR21TT2JydXJHS1ZjSGlPT3hQcWFMcXJIS1JVczM2RDdC?= =?utf-8?B?NGxHQytKYTJFRzJBS2NoZFZNdEppcitmbDVaNXArN29rU2RaVWFKVzU1aThB?= =?utf-8?B?MGY0ajFieG9UOHlXUW5Ldk1ZeG9nV3ZYcU9LcWxCWmVQY1NNaitjNlE1eSt1?= =?utf-8?Q?nVwjBLJRPHH2LU/Y6+zM=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;6:5QSOUN5bKhvJzLPvDp7GUySHO2jyA90AG87D7OPmerg0MrSSZiTeVtltjTNl36fRy3I8YRScqhkYXeukmkRinnbM16siyUZTCHFgqLEWVfFRHgdHLd0RMruFjCbWTFpJqUVCFSeSXlwf1ggiEvzzTDQy/IYt6Bj7kWC0OfOQqPg4tNjD8Rn4c5aMogRRCaLothJoAw1cV+wu5XsRO6CsFeevXpLxs/xt2zrtJL6C4rm3A8+sHHbGF+NKiw6ETk5NSuMnM2uScCjBOQHVA1puzbDQUVG0EqNCiv1LNOWpMjrTatupaV1auNrCJISpx1CQDF/OCVAOrjH/xyA/z6E5rQ==;5:wcWZeYm+ILGzEy6XuT6k7q/ZcDWziZLPS8eHXevVbdKwEjU+RPfEb5cJE3kko3eDVCGH41yhdT4BMdUbxVxE8ofCB5ncGpB3CqkTzzRKf30brJmA28jDTUNuLGDlb+xHUIcx7Hx4myrwZ6nhjBaenQ==;24:b+8Gk4WzpcpEIzlobiSRU5zaKdtewSYG1tXuaJ0nCuX0aeQqZkrphPcJAZCe52kwrB81v3gpceO2xOaV8VPGJ+L08JlTMLBSlycg1xsMzv8=;7:tnghQYMrA+u7faMFLioojS7ydK2MTAEOkizetz+cTqkIV38SwuTfYeGu1QpyVFFxWA/zu0SIDFuNYIBJg5e4frNdvhaFWheQdmYDsWsipCqdg8fkWd1FAVDjAHILlhnEDlnCtWmDqdxZwKrTbfPTTyAVsIGJHA/LW+vSCJgL77kpTIwFh7DkAzYkRohHUR0wlBYG0LTjltWLU7cWtx4xDTcFEMUDHdEhdsYcehe5EMc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 07:49:49.3633 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1936 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.9.2017 16:34, Andrew Lunn wrote: > On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote: >> To clear Speed Selection in MDIO control register(0x10), >> ie, clear bits 6 and 13 to zero while keeping other bits same. >> Before AND operation,The Mask value has to be perform with bitwise NOT >> operation (ie, ~ operator) >> >> This patch clears current speed selection before writing the >> new speed settings to gmii2rgmii converter > > Hi Fahad > > I expect you will find other issues with this driver. I pointed some > out at the time it is submitted, but the developers went quiet as soon > as it was accepted. Can you please point me to that email? I will create ticket about it in our system to get them resolved. Thanks, Michal