From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49222.qiye.163.com (mail-m49222.qiye.163.com [45.254.49.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B578A379C44 for ; Sun, 13 Sep 2026 06:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.222 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789280551; cv=none; b=ZlJ1mBOdvYNPAyN1ZljxZgykf1XzzxKpVS5fpObi6o49+dYuFvGEmE0mDrjf5bZ7711ke69DnBCOi25pRdCYm/vUaeCZHQa1mNiBk+3zB0C6R3VOxGPMj/Wla0EA7i0j/VKLcMlvP2WLMvTTxXll2I2TAkbh6s5cpiPwvCq7ybI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789280551; c=relaxed/simple; bh=frmmjL0pUR4lIvSf8LqhHwrzE1zPkdDrOZcolIGlvFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I2ZRMl9Mxmgl7oEubCzPvvQEKk23qOyUNm9zNzjY9QeOzYPlDdDjVE1YfbPUxRg5MCDmaIbQlsNVPKal1SXBK/HGalncE1Wiw5YcnU0d8VmLPvjG7lZd/zEYdNGHBLD+dgrNrX2NkMnvC2WTeCTL95X5PEvP/B8xEvh70Xe/2So= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=GAJ5dMwy; arc=none smtp.client-ip=45.254.49.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="GAJ5dMwy" Received: from [127.0.0.1] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 4d8d80e68; Sun, 13 Sep 2026 14:17:08 +0800 (GMT+08:00) Message-ID: <5f5a3210-44e1-4d56-ab44-aea2fe3cabae@rock-chips.com> Date: Sun, 13 Sep 2026 14:17:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] drm/rockchip: dsi: Add maximum per lane bit rate calculation To: Heiko Stuebner Cc: Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chaoyi Chen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260812073002.328-1-kernel@airkyi.com> <20260812073002.328-2-kernel@airkyi.com> <9674763.CDJkKcVGEf@phil> Content-Language: en-US From: Chaoyi Chen In-Reply-To: <9674763.CDJkKcVGEf@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa09969941d03a7kunm769b3eaa96f912 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCTEsfVhlCTUkZSh4dH05LGlYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=GAJ5dMwy21VmCnJabb1L9TQt7b2IDU9Uq/uVBCd3W1ZJPdjMZOkOHgn5LiqAgg3GA0pHy4C3q4EUx4G7Hz1skBBdZLC9AW8rueILzdxDsEfhB5+YqQqTqewhPSW77CuWLWUJinCQ0Gmq7MLqHcATbjzdyKYT8nT+8AEEL8AngmA=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=XE0FAIY1dIyIhNWdzfvXZWvPYm623Zb2EGWRdg2QQio=; h=date:mime-version:subject:message-id:from; Hi Heiko, On 9/12/2026 8:32 PM, Heiko Stuebner wrote: > Am Mittwoch, 12. August 2026, 09:30:00 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen: >> From: Chaoyi Chen >> >> Different chips have varying support for the maximum bit rate per lane. >> >> Add calculation for the maximum per lane bit rate for various chip >> platforms. >> >> Signed-off-by: Chaoyi Chen > > [...] > >> @@ -573,6 +574,7 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode, >> unsigned long _fbdiv, best_fbdiv; >> unsigned long min_delta = ULONG_MAX; >> >> + max_mbps = dsi->cdata->max_bit_rate_per_lane / USEC_PER_SEC; > > As the value is called max_bit_rate_per_lane, I guess Sashiko > is correct in that the max_mbps check should use "<=" ? > Thanks for pointing this out. I'll fix it in v5. > > Heiko -- Best, Chaoyi