From: Haifeng Xu <haifeng.xu@shopee.com>
To: ye.xingchen@zte.com.cn, rafael.j.wysocki@intel.com
Cc: peterz@infradead.org, ebiederm@xmission.com, elver@google.com,
tglx@linutronix.de, michael.christie@oracle.com,
viro@zeniv.linux.org.uk, mcgrof@kernel.org, dvyukov@google.com,
vincent.whitchurch@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signal: remove duplicate include header in signal.c
Date: Mon, 10 Jul 2023 18:11:39 +0800 [thread overview]
Message-ID: <5f5a3d4c-34fb-9d9b-444f-da8f7389ab76@shopee.com> (raw)
In-Reply-To: <202307101523409041269@zte.com.cn>
On 2023/7/10 15:23, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> linux/file.h is included more than once.
Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?
Thanks, Haifeng.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
> #include <linux/mm.h>
> #include <linux/proc_fs.h>
> #include <linux/tty.h>
> -#include <linux/file.h>
> #include <linux/binfmts.h>
> #include <linux/coredump.h>
> #include <linux/security.h>
prev parent reply other threads:[~2023-07-10 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 7:23 ye.xingchen
2023-07-10 10:11 ` Haifeng Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f5a3d4c-34fb-9d9b-444f-da8f7389ab76@shopee.com \
--to=haifeng.xu@shopee.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=michael.christie@oracle.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.whitchurch@axis.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®