From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbdJJTfO (ORCPT ); Tue, 10 Oct 2017 15:35:14 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36817 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbdJJTfM (ORCPT ); Tue, 10 Oct 2017 15:35:12 -0400 X-Google-Smtp-Source: AOwi7QDTWVtJoxe3ep8ozUQYzBSlwl9+D/Yvx8yt2fQJ40FD4qNBamf7gzZQwvH08Q8c7IV8w29GYw== From: Jes Sorensen X-Google-Original-From: Jes Sorensen Subject: Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs To: "Gustavo A. R. Silva" , Kalle Valo Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171010193027.GA23108@embeddedor.com> Message-ID: <5f5f0f54-d901-90be-9025-0a1c4b909368@gmail.com> Date: Tue, 10 Oct 2017 15:35:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171010193027.GA23108@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. While this isn't harmful, to me this looks like pointless patch churn for zero gain and it's just ugly. Jes > Cc: Jes Sorensen > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 7806a4d..e66be05 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -1153,6 +1153,7 @@ void rtl8xxxu_gen1_config_channel(struct ieee80211_hw *hw) > switch (hw->conf.chandef.width) { > case NL80211_CHAN_WIDTH_20_NOHT: > ht = false; > + /* fall through */ > case NL80211_CHAN_WIDTH_20: > opmode |= BW_OPMODE_20MHZ; > rtl8xxxu_write8(priv, REG_BW_OPMODE, opmode); > @@ -1280,6 +1281,7 @@ void rtl8xxxu_gen2_config_channel(struct ieee80211_hw *hw) > switch (hw->conf.chandef.width) { > case NL80211_CHAN_WIDTH_20_NOHT: > ht = false; > + /* fall through */ > case NL80211_CHAN_WIDTH_20: > rf_mode_bw |= WMAC_TRXPTCL_CTL_BW_20; > subchannel = 0; > @@ -1748,9 +1750,11 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv) > case 3: > priv->ep_tx_low_queue = 1; > priv->ep_tx_count++; > + /* fall through */ > case 2: > priv->ep_tx_normal_queue = 1; > priv->ep_tx_count++; > + /* fall through */ > case 1: > priv->ep_tx_high_queue = 1; > priv->ep_tx_count++; > @@ -5691,6 +5695,7 @@ static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, > break; > case WLAN_CIPHER_SUITE_TKIP: > key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; > + /* fall through */ > default: > return -EOPNOTSUPP; > } >