Re: [PATCH 2/5] [brcmfmac] Add support for 6G bands

[Arend van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On 10/20/2023 6:35 PM, Daniel Berlin wrote:
>>> @@ -6965,6 +7066,10 @@ static int brcmf_construct_chaninfo(struct brcmf_cfg80211_info *cfg,
>>>                for (i = 0; i < band->n_channels; i++)
>>>                        band->channels[i].flags = IEEE80211_CHAN_DISABLED;
>>>        band = wiphy->bands[NL80211_BAND_5GHZ];
>>> +     if (band)
>> Eh. Why is this conditional? We are creating all bands in the wiphy
>> instance so why the null check here?
> 
> I just matched what was there, I can remove all of them if we want.
> 
> (I'll take care of the rest of the comments between here)

I stumbled upon the bandlist usage later in this patch (I think) so we 
do add bands only when the device supports them. Hence you can ignore my 
comment here.

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]