mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <tomi.valkeinen@ti.com>,
	<airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<arnd@arndb.de>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] drm/tilcdc: add missing header dependencies
Date: Thu, 8 Sep 2016 15:57:54 +0300	[thread overview]
Message-ID: <5f679a13-2221-af54-3e80-e8cc8d26c7d1@ti.com> (raw)
In-Reply-To: <1473332936-25731-1-git-send-email-baoyou.xie@linaro.org>

On 09/08/16 14:08, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:443:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

I'll pick this up.
Thanks,
Jyri


> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 1 +
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index ff7774c..979394d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -24,6 +24,7 @@
>  #include <video/videomode.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>  
>  struct panel_module {
>  	struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 6b8c5b3..455f032 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -22,6 +22,7 @@
>  #include <linux/pinctrl/consumer.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>  
>  struct tfp410_module {
>  	struct tilcdc_module base;
> 

  reply	other threads:[~2016-09-08 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 11:08 Baoyou Xie
2016-09-08 12:57 ` Jyri Sarha [this message]
2016-09-21  5:12 Baoyou Xie
2016-09-22 15:56 ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f679a13-2221-af54-3e80-e8cc8d26c7d1@ti.com \
    --to=jsarha@ti.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=baoyou.xie@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®