From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76ECB14A4F9 for ; Sat, 11 Jan 2025 05:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736572844; cv=none; b=WaGZUiCgfM/AJMZR6NdDA3FT2Qg5zecCmpXO17qBiAu7ZRpWn+cTy3SqofMC2ACeibqSQG7JA3ssDLO/LmoHarARQt+j+YhCEL5f4zazXmqmDYVYO5eSeJULPk12tDXSRBc1g+M7vh/diJJClCHYl/QBCf8WahMhSUXb/AzRw9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736572844; c=relaxed/simple; bh=XVHylNyHspfxsR5nvSnwfDtdr3rAkF+h/5oVprq5HmI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZAzz/6AwDxCgz18+cobNcbUKygek/QwxRbtyP9c9aM5oCt4dg6rMqL0Q0QWMBsNqSK9bkzfKt7vvIO8R/Z+tkjybKozbPODxg3BUfqHIYo5TEDnwaMIjD1K9c4u6o8RUl5+/fE6OqJUeII4Vj1gfvPJOjV/zBL+8CO1RFYKq5dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=bOfXdCai; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="bOfXdCai" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2163b0c09afso48607665ad.0 for ; Fri, 10 Jan 2025 21:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1736572843; x=1737177643; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pK2F+RBTaMSDxoEAtE8SM5XYDPlI0601AzyscCoxm2I=; b=bOfXdCai1SgljamBeP8QyR/JOQ4FbYnxuK7GlXHkGsDCeuRp9U+8zmW3OJUq30S6B1 SLa6ui19ir6Lii6Trn9iWYfLppdt2W2DT2w6uVPu0JmvrGjHdcHfvfUrxUEcU8uJkXXL xL/mJqYiE8jR0eGvLV3CTmAFFoj8P0gn+JzbOc8tBxXMdCQwURAHVbMQTA6y3sf/fsrC XgLfftoWAKAE0rZKBAgYfjfI7C5co3rTYyLJZD2h2FcVghQVngthc0nH6jU9roNHK12Z wgCM/ETTekDHCgV/LyvrzNM1jNLyws6i6E1Km7UE513DdwrEWS8JILzSAYFUjCM9ksyk jLog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736572843; x=1737177643; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pK2F+RBTaMSDxoEAtE8SM5XYDPlI0601AzyscCoxm2I=; b=DUtLM9/bJr6ud9mX96e40lotNsqT5sO3+9cUWN597nEDhEhLW+TUl3ifJGBLSdeyY7 +YMg/pQhEaSl6NBMx5yEaOQqu2HOXM5v2NE6qp+ZxUL2Lh7em4Na3Rw21ZFEonHhpO8P qWJmFnUZ32cVA+uIVrCAPnWgghVZH1ut26f3l2hUP1qp0L4XcwFn2VEjDBboseFikAt3 OzM8E202ORneOQGk1ABVqtnXiQA5g3WmoZuTMCh5SqDQMDojs3b9nKwBtcOeaRW98SiQ qG7gIHwuxOmv9Wk0gurb+R2W69F3Ssm+rGSbP2Lp6DErM3jrZvONdbY19lAu21Eaxkzn G3NQ== X-Forwarded-Encrypted: i=1; AJvYcCXcpRC0YnDekvQTq33K5V8yz5GBcqaWr9Xkm5x/7ZjDeLd1c5znefXxjfn/bTtcoyiJ7zdcLlSxJkUpuv0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6UTjFSqzxBnRjz1cKt/psltcr2pBAtlXpsUSnIKypOxf5AXpq WS9mSKzJEmMkYgl7Ki3dgAfgCjpsvWXpXbelrWT8ugg97AsQIHKbazwSzoYQbk8= X-Gm-Gg: ASbGnctEuUySoAceGM6llBav+O/1M8mB9FTFrWiQ4zMsZ3YjqUNZKTWrirly8Tunzri k7N7B6IYRqiI7xQOm74CWh5Gy0dJyVYjgF2OBZFzh4Adz/cSJS8c8Pgxryrrm8oNuFyxAyFqyQ2 Su1DqOJxP+1Nlh1G9qinNRK9Rdmqb2HvAogLoI8MVXC2Pe/+05AvtHkBZ/XeRtgob0jMh/JoHHR C6scK2Bzfh05Dz5J2BxIQXRBRlCnE4e+DaHnKw3zdNUxOnnqzY9ZxMznk6P1F3m0Sg= X-Google-Smtp-Source: AGHT+IGBR3qO11ykBQufc7YwvifpdR2xYxMPWXbJI07PD0vx+LDE0o4MSNzVKFuQj6IitF6hcz/7jA== X-Received: by 2002:a05:6a00:858a:b0:727:d55e:4bee with SMTP id d2e1a72fcca58-72d21f112c8mr16427488b3a.1.1736572842758; Fri, 10 Jan 2025 21:20:42 -0800 (PST) Received: from [157.82.203.37] ([157.82.203.37]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a3c259314b1sm3095729a12.9.2025.01.10.21.20.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 21:20:42 -0800 (PST) Message-ID: <5f689383-055e-4140-8b87-1f1fa92634e8@daynix.com> Date: Sat, 11 Jan 2025 14:20:39 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Documentation: Fix config_acs= example To: Jonathan Corbet , Bjorn Helgaas Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20240915-acs-v1-1-b9ee536ee9bd@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: <20240915-acs-v1-1-b9ee536ee9bd@daynix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, It seems this patch has been forgotten for a while but it is still valid. Can anyone take a look at this? On 2024/09/15 10:36, Akihiko Odaki wrote: > The documentation used to say: >> For example, >> pci=config_acs=10x >> would configure all devices that support ACS to enable P2P Request >> Redirect, disable Translation Blocking, and leave Source Validation >> unchanged from whatever power-up or firmware set it to. > > However, a flag specification always needs to be suffixed with "@" and a > PCI device string, which is missing in this example. It needs to be > suffixed with "@pci:0:0" to configure all devices that support ACS in > particular. > > Signed-off-by: Akihiko Odaki > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index ee2984e46c06..5611903c27a9 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -4604,7 +4604,7 @@ > '1' – force enabled > 'x' – unchanged > For example, > - pci=config_acs=10x > + pci=config_acs=10x@pci:0:0 > would configure all devices that support > ACS to enable P2P Request Redirect, disable > Translation Blocking, and leave Source > > --- > base-commit: 46a0057a5853cbdb58211c19e89ba7777dc6fd50 > change-id: 20240911-acs-3043a2737cc9 > > Best regards,