From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11022125.outbound.protection.outlook.com [40.107.193.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8CA13EAC7E for ; Tue, 17 Mar 2026 15:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.193.125 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773762116; cv=fail; b=Ke4D3NLjjSRv88i5elH2m+/BsUMHLfCZsSQ6cypgWsj9mo5UWDXDlQezxMzCoxWdezalelDu108RVJO9r8DL1yb7y4JfBSHiHVdO0YtbdGVbdkX+MeggemI57m+csmcx1drkF3+MRBPSqVlsTensPMG7HUum6l1mz5P79bBszc4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773762116; c=relaxed/simple; bh=1kcgGsznVfxbzIiKWSQBYA7FPdEZEzUPOK9WfDluYCY=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=nHa/V4x1ygjO2nV9JhJcI1Ry719lHM6FwHrl4AXIzrg66FLp4ul2ZzeciAzc0SEAcXQhrNWf47eoGsBlzYQFLPpL6cKPs4O6yVnbgEho84AXkkCXvmjWjKoHIfedY7i7ckan1oLgD3PwteR3J3mckLkZSMd4H6VIOoiMBPT5zgs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=uQp03+GF; arc=fail smtp.client-ip=40.107.193.125 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="uQp03+GF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AtqA6SQNJJrQkQULNAYHTzslt0LYTU5xln/fzKSv17Sx5f+hCaD/udAead2pMWxjI4iIVhvK3qFHINeE+1yX1KMHlcJ8MDXRtczEso4Aw3ZR0NJtLcjriuRU0P146m1qrhH3JMwm7fisBulKEHZJweuXUfyQU/6Rax5bla6JjOYXd/0W9aMXngMN7cpJ1Dab1D6r9e8jQDww4ujdZK0qUoAA16E2RT+XcrLvZpI9kphf0HzFrjja59YPyT/vTYwHl5+dCyYpPj1Q7tRnU7f8Jzb2U5vbixTyA+jnkMU3ZguwOgK7S9noOx/BjnIYrNgE7mMWOTdeIPKdyyhUaQXLxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EtTGFjQi+MOCuSOW0yKWWq6tcMNUlLON5tNUlKSrc7k=; b=Z1NpgZGfPmlAJpMARictPBKCtpqVjVjLGRHF20SloKS8/uqpAOcYMRNxNDyk9I6BgwcqpJ/fc/u9eTR8hpnm5bjYNE8hcq0t46U2IeSQX+E4aPNq7Ql05bPX0D9skW2aUlyhAW1YYav/mZOE8lW3Ko5aeRPAVvNYJiN+z052/yDZDZ6IBATvqWqgR5eXJJhQBmuKzsN2dbGPxP4JxG4okCb6P3ygj/HUgMCI1Nsr1zYljeV0DdIOO58Min2hyyps+sgLceM4VlursVNHF7mKre9Mz4yBOB7FpTIEkPEf9fLdpM9VscTmqLNJIiKnNa7wbondhnZ6gRAf6m/L2WXakQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EtTGFjQi+MOCuSOW0yKWWq6tcMNUlLON5tNUlKSrc7k=; b=uQp03+GF6eeFBdM3NCbPgy44+AKhhuZeF9ObqFdy4roGMCrpQ1NFagaCoRDs/ke82phRBXWAV4x22rAJ2jfaYMPk7jq1ALF3RWZD1UX9nGvLcET7R/UG05z7OzUk2X48JfDDdnCT9VwwGPq/Yzp+k1Ag/e0F0rAMuXsk2l1YLLdWNoHuFnKM6/KMnYweFDDjAxRmiGfRn4NV0RKk/2YhuY+pNfWmkvkhqtrGOU0DWg4puHbq2DI+VC/c5Cu4aAm9Y80tiMP0l+nWC6VPZZor6/iAbk9p4IpDGTc7c4BclhkPIcINWSlQT0u4dIThbenh/cZYJa8dEmiBA3aM+dgnVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YQBPR01MB11211.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:93::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 17 Mar 2026 15:41:49 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1%3]) with mapi id 15.20.9700.024; Tue, 17 Mar 2026 15:41:47 +0000 Message-ID: <5f6a0278-d3d0-42fe-a2bb-38917d4bbdc3@efficios.com> Date: Tue, 17 Mar 2026 11:41:46 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib: skip percpu_counter_tree boundary kunit tests on single-CPU To: David Carlier , Andrew Morton , Josh Law , Mark Brown Cc: linux-kernel@vger.kernel.org References: <20260317150638.37438-1-devnexen@gmail.com> <20260317153915.43559-1-devnexen@gmail.com> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20260317153915.43559-1-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4P288CA0005.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::27) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YQBPR01MB11211:EE_ X-MS-Office365-Filtering-Correlation-Id: 709b0d28-594c-4b71-9586-08de843bb2b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|22082099003|56012099003|18002099003|7053199007; X-Microsoft-Antispam-Message-Info: B24oEst3hPLzLbrX8eM1yIsZafaLcCP7tGt9sBl51ESYFkprKL8PmMJhWR97hwtwUPl3mX5pb02wFwPhB7D6TiT6bz3eTPHK5c2umUOg+n81C3MmcBIB4ptdZxGabOrZ4bMiTKebE0iou+6N9lF2Rn19PAHBu65KkNuly4zwhmIz9/qqrQ1Fk87EaMXbSYJuIgaScRj4Vzf+odR8duW06s1ZWG+8cgcT4IfMo2bZFYMZjMfvESb7u7SIygrZ41JLn9cC7Q76pKDeJfL5KcCjlyjT9ueymXQrs6191cvIN1LIleqVc/JB8uqqJ/OeqfapQ8JI2R21WTAbCpIXiKu8/Q+Pionr9pWP219cw+3O/6HL9/Y5bSBApB/ZnI9RImIu2kRHa093u3uoElbaEMaOx65oBU+4gGd72wuRVCEfv650z+S7vx6MlGYw0N0+1MCh0cuUxCgThrpJ+hYXixd17Ft+Cac9pKVN6cb60vzQt0Sakb3+PygzHsXF5Hv1YzJe+8S9hwdJ3C/lOvvOPZ9jo3MF2kYQppao9W4oTvPxKSe+l7kVvR38dZVoXu1GcRdqT7nLYweIwV4pQoeHeD2dkFeHB8kgkRsozMB8XDlbiB9c49ysBRQ4QBaKhtAO99+xqbRuAzEb8Vpi396i2k2+uDvFNFNKUUHKcHEHGf8VNO878YX9Yq7ufeElrXxFr0W7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(22082099003)(56012099003)(18002099003)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmN5UTJaR01CRHdjRW0xR20zMVpwSnFSWmQyWnZkZlVzUytUNFFPeVhHNU9I?= =?utf-8?B?M3hBUGY5RDUwRXlKYkNBbjBDZXU3RHV1ZXRnVDAybE5NT2VLM3ZXRzdwczhN?= =?utf-8?B?OWhaZEdQOXZOd1hxNmpvb2ZHbG9EM29iVDhPa05lYTFlUEgwcmZWK2FxQjZC?= =?utf-8?B?Z3QxZGhOT2lEMmpUdkp6dURlQ2loZ1BSWWlvUFo1Nnl6UzZjOWFSYmwxZjE0?= =?utf-8?B?RVBJcElKTS83eFNOT3NYZVhJQ1pWSTBBVGJCSGh4SGZQTjRiN3daeVp0TmNR?= =?utf-8?B?RXZGR1VXV1Q3OTd3emFwVlhpc0dIT0x3K2hwVWlUSExBNlAreDA4bU1SRjc4?= =?utf-8?B?SlFNalZXM2tod3pCQWlSamlQd0QwTEFmalM0amJTSUswVHZqd2x4VnljYTJB?= =?utf-8?B?aG1YUktJS25zVEo3K3F3RXcwY3huMmtWbFdWT1J6enlDUk5TQWNSYjBMRG1K?= =?utf-8?B?aUtDT29jaWFYVFBTMWU4dDNUVkd5K1U1RkhDUWxxQWNiTVlTS0NYRUtheDRz?= =?utf-8?B?THNSWU1LaEdLNXJPUmQvU0NhdzV4NUtMb3JwTUhrckJRV1oyYitMU2o2ZHZO?= =?utf-8?B?b1FCblVZZk5kaG5UMW5LcnExbVJXWFU4SjR3SjlvdnlVbUl4a1FwV1RXUmoz?= =?utf-8?B?YUgxOFN6bkN4RVJQSnl4U2JlVUE4TDBvV203UkZWc284eGNqZDZtVWVJejBG?= =?utf-8?B?OGpnTEF6d3dGeGE0SzU3bFMzc296c0tWenZtdXRNWk1qTFJHZnFyY0ZzQzV3?= =?utf-8?B?RUVYbmZ3WUU4QjkwZ3VRaDIrTklDUkZUOEMxeFNvVTV2Uk5GaDlpREQ1L204?= =?utf-8?B?cW1zc2VTZTJXc1k5SktvRlQ4Z0Y3MjQ3NjA5d0RMOXU1NFNOQjRwNURBcnJK?= =?utf-8?B?TVlKQXQ5YzRoRjdSMFBZK3h0eURSa1hKc3Zkck9GNkkxNGs4aElIS3dPbGJa?= =?utf-8?B?ZzgzNmF0NFlXY2ZHM0ZpZ2E5ZmE2N0hpL3NWRG5UbmV3QjFoWk1QSnppdTh3?= =?utf-8?B?QUtyTzdnWW9lZEg4cW9xWWZhUDZCU3VjcDEwaTRSc2wyVm45ekZJeW9XbmRP?= =?utf-8?B?ME1OdHlML2dlM0poQmtXL1dhN1pCWjhXZGd1ZkQ2dlhYQnI4TmxYa1l4dHJ3?= =?utf-8?B?U2tqNDhydTIrTHcvaTJRTkE1K3N3bFNQUlI3bndwbkdCOThXc1NYR0NKUmha?= =?utf-8?B?SUEyaFJHSm9UdGZMWllqUFFMNzE4eGRuZjIyYU9uWVgzTVMrNnlvSWdVcExL?= =?utf-8?B?ZDVSVW5LTTRwZW1Wd2swNWw1QWhnTjNZTXdmWE1pRExReWlJL2VXaFl1Qndn?= =?utf-8?B?Q24wZ1Fobkh1ZFd3Nm9mMms1U0FaNGt6OE1GYlNqTkZsVFNNTkxtSjZMYVF2?= =?utf-8?B?Q3oxa1NNVjJQblhuMzFFOTh6b1AvRUc3bE42aUNJK25maGtGVUZOZ1p0S2tY?= =?utf-8?B?cG8yb2IyYTAwTFl4bFhtaDBPb0twRzFtbytXQllGR25BYUR0MC9KN2QyK21L?= =?utf-8?B?azNLOUl6bWhjTDdRbXJlSlJEaWNjMVNEV2EzanB3eEloS3pXWWV0bkpUL2pv?= =?utf-8?B?RGwzc0VqUWdHQTFOYjE0U0UzTjJNelJ5dGt3Rm9yNlQrekRpUE8vVko1Vzht?= =?utf-8?B?eTU3SURPalRMaWs4Z215QUZnKzJSWUZXemJVMFVvcHJaVzRzeXRjelNPR2p1?= =?utf-8?B?YjBQOTA3RVZyY09XVkJHbXBIZytuL1FHODZHNktTN1ZXSkpaNFpwcTBUSitw?= =?utf-8?B?RXh5ZVEwRnZZUzRDaDFqQXEzQ2ZyR1oxT1BDSTVhYVpaVVk4bDlWOWZ6eElq?= =?utf-8?B?dk5hNTBTN2NsS2NpZ0w4Uk1LMlNvMmV1V0RQUi8xcGN3eGZhWkJoQzhhbXFl?= =?utf-8?B?NzBWcllCWC85QlNwdkFaNm93Tmt0bzAvbk0xaCtGcHRPZm9wUGpEUGlKRHJE?= =?utf-8?B?d3czYldCUUR1WGJWQzRVdnFQWlVtV3I0VkxsTWdBUTNqbmNKNzYzVXpqS0V1?= =?utf-8?B?dnhWSXJGYVdORXpPTU9XbEFmNElXOEp6M3NaUDBpbHowMnlOczhERXJsY3py?= =?utf-8?B?bS9ZcWFGeWJ2dk84LzFpMnArcW1hbDhGMTRmZjA0ZnIvZWlSemJlQS9Sd0RZ?= =?utf-8?B?djlVTnpxZWFNOEJZeXhkcGk1Szc1QVJJTkRRWm9iZDI3TGRpZk9RbHorRXdv?= =?utf-8?B?bTZLRnlBQ2gxRytsdXdpeU4rTUIwc1VrZVZQZWNMMDlvbFVGR0RjRFFLWEhP?= =?utf-8?B?Z2J1WEdMWWF5VHRDUW01YVZtYXFoamwvc0U3cnRSYXlTbkFnT0x3Q2ZTdHZV?= =?utf-8?B?QTNMRE9xUjBvSzN5OHdRekJESG0vWXJLTnF2ZUZKS05yYUEvalljVEZibkJk?= =?utf-8?Q?/ri6eABsFOZtRQG7Aq7iBX4BTz0d4yxzusUJ8?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 709b0d28-594c-4b71-9586-08de843bb2b0 X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 15:41:47.0127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FBj219DlA5o1IW+P7mroimjzZQ6i4pPZ3SyR+A8Qu1Pp2mtg7QkJ88JOOLGlNybAiMZLtL32T45du0288cEP+Hecb3mgujGhG1ljU1dyPOE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR01MB11211 On 2026-03-17 11:39, David Carlier wrote: > On single-CPU topologies, accuracy_multiplier is zero, making both > approx_accuracy_range.under and .over zero. The boundary tests in > hpcc_test_compare_value_boundaries and hpcc_test_compare_counter_boundaries > then degenerate to comparing 0 vs 0, which correctly returns 0 (equal) > but the tests expect nonzero results. > > Skip these boundary tests with kunit_skip() when accuracy is zero, > since approximation boundaries are meaningless without multi-CPU carry > propagation. Use percpu_counter_tree_items_size() as the topology check > before any allocations to avoid leaking memory on skip. > > Fixes: ebc1ff504f55 ("lib: add kunit boundary tests for percpu_counter_tree comparisons") > Signed-off-by: David Carlier Thanks! Reviewed-by: Mathieu Desnoyers > --- > lib/tests/percpu_counter_tree_kunit.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/tests/percpu_counter_tree_kunit.c b/lib/tests/percpu_counter_tree_kunit.c > index 4d058bc78f7d..b773d20867d4 100644 > --- a/lib/tests/percpu_counter_tree_kunit.c > +++ b/lib/tests/percpu_counter_tree_kunit.c > @@ -93,6 +93,9 @@ static void hpcc_test_compare_value_boundaries(struct kunit *test) > unsigned long under = 0, over = 0; > int ret; > > + if (!percpu_counter_tree_items_size()) > + kunit_skip(test, "no approximation accuracy on single-CPU topology"); > + > counter_items = kzalloc(percpu_counter_tree_items_size(), GFP_KERNEL); > KUNIT_ASSERT_PTR_NE(test, counter_items, NULL); > ret = percpu_counter_tree_init(&pct, counter_items, 32, GFP_KERNEL); > @@ -197,6 +200,9 @@ static void hpcc_test_compare_counter_boundaries(struct kunit *test) > unsigned long combined; > int ret; > > + if (!percpu_counter_tree_items_size()) > + kunit_skip(test, "no approximation accuracy on single-CPU topology"); > + > counter_items = kzalloc(percpu_counter_tree_items_size() * 2, > GFP_KERNEL); > KUNIT_ASSERT_PTR_NE(test, counter_items, NULL); -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com