From: Dave Hansen <dave.hansen@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix pgprotval_t format string
Date: Tue, 10 Apr 2018 13:00:25 -0700 [thread overview]
Message-ID: <5f6f0b92-9774-2dc8-c28b-4a9e3a9a211d@linux.intel.com> (raw)
In-Reply-To: <20180410084424.2935759-1-arnd@arndb.de>
On 04/10/2018 01:43 AM, Arnd Bergmann wrote:
> --- a/arch/x86/include/asm/pgtable.h
> +++ b/arch/x86/include/asm/pgtable.h
> @@ -533,11 +533,11 @@ static inline pgprotval_t check_pgprot(pgprot_t pgprot)
> /* mmdebug.h can not be included here because of dependencies */
> #ifdef CONFIG_DEBUG_VM
> WARN_ONCE(pgprot_val(pgprot) != massaged_val,
> - "attempted to set unsupported pgprot: %016lx "
> - "bits: %016lx supported: %016lx\n",
> - pgprot_val(pgprot),
> - pgprot_val(pgprot) ^ massaged_val,
> - __supported_pte_mask);
> + "attempted to set unsupported pgprot: %016llx "
> + "bits: %016llx supported: %016llx\n",
> + (u64)pgprot_val(pgprot),
> + (u64)pgprot_val(pgprot) ^ massaged_val,
> + (u64)__supported_pte_mask);
> #endif
Whoops, I just sent a similar patch. I just used 'unsigned long long'
instead of u64. I'm fine with this as well, and don't prefer one over
the other, so:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2018-04-10 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 8:43 Arnd Bergmann
2018-04-10 20:00 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f6f0b92-9774-2dc8-c28b-4a9e3a9a211d@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®