From: Andrew Lunn <andrew@lunn.ch>
To: Divya.Koppera@microchip.com
Cc: josef@raschen.org, Arun.Ramadoss@microchip.com,
UNGLinuxDriver@microchip.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.
Date: Mon, 6 Oct 2025 20:44:43 +0200 [thread overview]
Message-ID: <5f74c41e-15cd-40f3-8fb2-fa636f169d70@lunn.ch> (raw)
In-Reply-To: <DS7PR11MB6102D0B2985344C770AEC293E2E4A@DS7PR11MB6102.namprd11.prod.outlook.com>
> phy_sanitize_settings() is supposed to pick the least supported
> speed from the supported list when speed is not initialized.
What makes you think it should pick the slowest speed? The kdoc for
the function is:
/**
* phy_sanitize_settings - make sure the PHY is set to supported speed and duplex
* @phydev: the target phy_device struct
*
* Description: Make sure the PHY is set to supported speeds and
* duplexes. Drop down by one in this order: 1000/FULL,
* 1000/HALF, 100/FULL, 100/HALF, 10/FULL, 10/HALF.
So it should pick 1000Full if available. If not it will try 1000Half,
if not 100Full etc.
And the comment is actually a bit out of date. It will actually start
from 800G Full, 400G Full, 200G Full, 100G Full, not that anybody does
Copper at these speeds.
Andrew
next prev parent reply other threads:[~2025-10-06 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:52 Josef Raschen
2025-09-25 22:00 ` Andrew Lunn
2025-09-26 21:24 ` Josef Raschen
2025-09-26 21:46 ` Andrew Lunn
2025-09-29 19:30 ` Josef Raschen
2025-10-03 12:59 ` Divya.Koppera
2025-10-06 18:44 ` Andrew Lunn [this message]
2025-10-07 6:01 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f74c41e-15cd-40f3-8fb2-fa636f169d70@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arun.Ramadoss@microchip.com \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=josef@raschen.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®