From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6796BC17440 for ; Wed, 13 Nov 2019 01:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 405F7222C6 for ; Wed, 13 Nov 2019 01:13:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=themaw.net header.i=@themaw.net header.b="WSfeS8ak"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="S4DmqHqE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbfKMBNc (ORCPT ); Tue, 12 Nov 2019 20:13:32 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43857 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726979AbfKMBNb (ORCPT ); Tue, 12 Nov 2019 20:13:31 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D2B5621B55; Tue, 12 Nov 2019 20:13:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Nov 2019 20:13:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm1; bh= /zCvsz2UmlaGRP+ibIQ/q5XTxRY0oupK+ptfh45XkeM=; b=WSfeS8akzcvt1+Sd lg+4NHlU2tgbNEgX+HsXn0zR2G+t3CwHvozbTcxZUfz8eWp2FOOhtBqYQXWFeQUa TkB0JS4iOgNKxOb/0tAa+Imix2NNQyYpIpzEU4gnRHyoDy+B+1d/g4bPZg+FBkUS W8qxT/S+BR84v+1ui6+Lbs4ZX4q7qQgYV9aYaVon4EQ2e7iGaSqnKX7ox4qUVNzB i20+egenxBlRbAIjtlg6zHa5lBsTfcav1rbLcI6k4fj4OJIRguMh+rS5HBw2nCav ondJzKwhInPsFtjm1s/r+FzHIFPZ57TIlrs7KxZuin4V7pd2jx/ScYFM/EMlLG2I tXwOSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/zCvsz2UmlaGRP+ibIQ/q5XTxRY0oupK+ptfh45Xk eM=; b=S4DmqHqEOLVCAP3J/NmyBQI4huVkyWLfHJ0RMTgZeB3wPiJ8JoYpZFY48 Luzwk7b2vTDfxhnZwuTctUF4LHUmG7BxcZhEXJPJ2FbVt2NiRohXmWtqpxpiksm6 nvoqfNmi0qBd+JJnihRIOXWfFyCjt1zxrcc0kCkXb9eW1cPdapW2ntr9Qv7oJ45+ Lf83UZ2z0xJUTH/VC4YmuPWeykJl24XoijjXE2DyRjGZujb9CczIS41b6T0docjf F+ofsuaxAb0PNvE+fe1CSLaXlK3v4b48ZJIyUVk+K92KyjYDxXavKRTYSlAvDOTe yjNNUTzPXCe97OwgkorCb/CyHi0bA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeftddgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthejredttderjeenucfhrhhomhepkfgrnhcu mfgvnhhtuceorhgrvhgvnhesthhhvghmrgifrdhnvghtqeenucffohhmrghinhepkhhmsh hgrdguvghvpdhgihhthhhusgdrtghomhenucfkphepuddukedrvddtkedrudekledrudek necurfgrrhgrmhepmhgrihhlfhhrohhmpehrrghvvghnsehthhgvmhgrfidrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mickey.themaw.net (unknown [118.208.189.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 04FBD306005E; Tue, 12 Nov 2019 20:13:25 -0500 (EST) Message-ID: <5f758be455bb8f761d028ea078b3e2a618dfd4b1.camel@themaw.net> Subject: Re: [LTP] [xfs] 73e5fff98b: kmsg.dev/zero:Can't_open_blockdev From: Ian Kent To: Christoph Hellwig , Jan Stancek Cc: kernel test robot , "Darrick J. Wong" , LKML , linux-xfs@vger.kernel.org, lkp@lists.01.org, ltp@lists.linux.it, DavidHowells , AlViro Date: Wed, 13 Nov 2019 09:13:22 +0800 In-Reply-To: <20191112120818.GA8858@lst.de> References: <20191111010022.GH29418@shao2-debian> <3fb8b1b04dd7808b45caf5262ee629c09c71e0b6.camel@themaw.net> <1108442397.11662343.1573560143066.JavaMail.zimbra@redhat.com> <20191112120818.GA8858@lst.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Al and David to the CC, hopefully that will draw their attention to this a bit sooner. On Tue, 2019-11-12 at 13:08 +0100, Christoph Hellwig wrote: > On Tue, Nov 12, 2019 at 07:02:23AM -0500, Jan Stancek wrote: > > https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/fs/fs_fill/fs_fill.c > > > > Setup of that test is trying different file system types, and it > > looks > > at errno code of "mount -t $fs /dev/zero /mnt/$fs". > > > > Test still PASSes. This report appears to be only about extra > > message in dmesg, > > which wasn't there before: > > > > # mount -t xfs /dev/zero /mnt/xfs Assuming that is what is being done ... > > # dmesg -c > > [ 897.177168] /dev/zero: Can't open blockdev > > That message comes from fs/super.c:get_tree_bdev(), a common library > used by all block device based file systems using the new mount API. I'll have a look at get_tree_bdev() but when I compared mount_bdev() to get_tree_bdev() before using it they looked like they did pretty much the same thing. I don't know how /dev/zero is meant to be handled, I'll need to try and work that out if Al or David don't see this soon enough. > > It doesn't seem all that useful to me, but it is something we'll > need to discuss with David and Al, not the XFS maintainers. Ian