Re: [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

[Damien Le Moal <dlemoal@kernel.org>]

On 4/25/25 05:43, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drive work again
> after regression in 6.9.0 when LPM was enabled,
> so disable it for this model
> 
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>

I still cannot apply this. I get the errors:

error: corrupt patch at line 10
error: could not build fake ancestor

Your base-commit is Linus tag for Linux 6.14, which is not appropriate for new
patches. Please rebase this on libata for-6.15-fixes branch or Linus latest tree.

Also please properly format you commit message to use up to 72 characters per
line. And terminate your sentence with a period please.

> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index d956735e2a76..c429ba259548 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4208,6 +4208,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
>        { "WDC WD3000JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
>        { "WDC WD3200JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
> 
> +       /*
> +        * This specific WD SATA-3 model has problems with LPM.
> +        */
> +       { "WDC WD20EFAX-68FB5N0",       NULL,   ATA_QUIRK_NOLPM },
> +
>        /*
>         * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
>         * log page is accessed. Ensure we never ask for this log page with
> 
> base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
> --
> 2.47.2


-- 
Damien Le Moal
Western Digital Research