From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCC4C433F5 for ; Fri, 13 May 2022 10:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379458AbiEMKdB (ORCPT ); Fri, 13 May 2022 06:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379445AbiEMKc6 (ORCPT ); Fri, 13 May 2022 06:32:58 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D18C9ED8 for ; Fri, 13 May 2022 03:32:55 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id p4so9512279edx.0 for ; Fri, 13 May 2022 03:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=O6FiHPs6TyRR3hcZC36X6uXYX5doF+6brHiz72Bmp3Y=; b=ESeWu6hBSMOQJBwvo98owd3dc9xTpa8qMO8//YKXHXjKIGYKVo1JsZBsr6njl8ehSu 7E1K+hGXZtM2f9CE3cbGjof/WV4EeK9S3SwF2jFtH+1afXmrnnCG/m/TFRosldC1dzWE WedDyoMKeks19xDflSrq+4Lb4tbSwRJlFibN7/nxnKkcAJs/8FxuNqxnE4XRZU9pHnJ7 JM4np+n5LBPtvfY53RW7yyQA3Hi75fahXxsFnjbTUtIIxFXYgF2S2PMu2mvZ8Ge0cXwj 50/0sMzC+4ZHJQmdQHlZTZmbnp6vvML/MgMuPyLPXdtR6IwLZ8ydrhWtTncdxn5sLF0y a9sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=O6FiHPs6TyRR3hcZC36X6uXYX5doF+6brHiz72Bmp3Y=; b=Zswxb+hl2Tuh47CQNl7CfRtROnHQWVSCQE3iLAcS3ZZZeNQbnb7G5MqEY8ORvI2k7D vbi9ej67AWaoGa3IFNfGBQ/BDgS5rUVlF+/zrAF8hpcjbTP5MclPUU8NYxiasgSomAkL CBzulllKTNhUmwAPWWhWqEl23/a6Tfr7MdWbwTO61gn5KKr3QuTAMbRMsAJmaXoBL1qe TDVrjjVoRRL4k9Jagf3FnGqjh5/C3/4Y33cKLjNm7K/13hLaORPINPkU1rIdWJwtuc/y msfR1McFwbHRh/bV7dhf8sGOn3l2EBrM9pKl6pXacgEEDE08jcQRRkDaGri+1YxiPcFx 4Wjg== X-Gm-Message-State: AOAM531QeUhmMYfHGH7zUuGcAlxEjoIEEdrNbX36W1Dd6qi3KY8HhT7j Q6QtWGDqMu4Tujp5UcSr7FQfbg== X-Google-Smtp-Source: ABdhPJxnxBRqoRRtonBw76pxckczcwui8tR3W20OfcDi/UUxotwJDJc16TYmbr5VAXgcERSaecmHyQ== X-Received: by 2002:aa7:ca0d:0:b0:428:90ee:322c with SMTP id y13-20020aa7ca0d000000b0042890ee322cmr30383575eds.100.1652437973639; Fri, 13 May 2022 03:32:53 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id gv2-20020a1709072bc200b006f3ef214df5sm636959ejc.91.2022.05.13.03.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 03:32:53 -0700 (PDT) Message-ID: <5f7dfcba-7e65-4f54-8699-e44ce11e216e@linaro.org> Date: Fri, 13 May 2022 12:32:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Content-Language: en-US To: Krishna Kurapati PSSNV , Krzysztof Kozlowski , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Wesley Cheng , Vinod Koul Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, Sandeep Maheswaram References: <1652282793-5580-1-git-send-email-quic_kriskura@quicinc.com> <1652282793-5580-2-git-send-email-quic_kriskura@quicinc.com> <3abbb26f-9396-d024-67f6-f24f7db3408d@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <3abbb26f-9396-d024-67f6-f24f7db3408d@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/2022 09:33, Krishna Kurapati PSSNV wrote: > > On 5/11/2022 11:49 PM, Krzysztof Kozlowski wrote: >> On 11/05/2022 17:26, Krishna Kurapati wrote: >>> From: Sandeep Maheswaram >>> >>> Add device tree bindings for SNPS phy tuning parameters. >>> >>> Signed-off-by: Sandeep Maheswaram >>> Signed-off-by: Krishna Kurapati >>> --- >>> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 87 ++++++++++++++++++++++ >>> 1 file changed, 87 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> index 1ce251d..70efffe 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> @@ -53,6 +53,93 @@ properties: >>> vdda33-supply: >>> description: phandle to the regulator 3.3V supply node. >>> >>> + qcom,hs-disconnect-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the voltage level for the threshold used to >>> + detect a disconnect event at the host. Possible values are. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >> This means there is some minimum and maximum (100%)? >> >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,squelch-detector-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the voltage level for the threshold used to >>> + detect valid high-speed data. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,hs-amplitude-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the high-speed DC level voltage. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,pre-emphasis-duration-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This signal controls the duration for which the >>> + HS pre-emphasis current is sourced onto DP<#> or DM<#>. >>> + The HS Transmitter pre-emphasis duration is defined in terms of >>> + unit amounts. One unit of pre-emphasis duration is approximately >>> + 650 ps and is defined as 1X pre-emphasis duration. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,pre-emphasis-amplitude-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This signal controls the amount of current sourced to >>> + DP<#> and DM<#> after a J-to-K or K-to-J transition. >>> + The HS Transmitter pre-emphasis current is defined in terms of unit >>> + amounts. One unit amount is approximately 2 mA and is defined as >>> + 1X pre-emphasis current. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,hs-rise-fall-time-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the rise/fall times of the high-speed waveform. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >>> + The hardware accepts only discrete values. The value closest to the >>> + provided input will be chosen as the override value for this param. >>> + >>> + qcom,hs-crossover-voltage-mv: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the voltage at which the DP<#> and DM<#> >>> + signals cross while transmitting in HS mode. >>> + The values defined are in milli volts. The hardware accepts only >>> + discrete values. The value closest to the provided input will be >>> + chosen as the override value for this param. >>> + >>> + qcom,hs-output-impedance-mohm: >>> + $ref: /schemas/types.yaml#/definitions/int32 >> Here and in other places, please use standard units. See >> dtschema/schemas/property-units.yaml in dtschema repo. >> >> >> Best regards, >> Krzysztof > > Hi Krzystof, thanks for the input. > > I see there are microvolt and microohm units present in > schemas/property-units.yaml > > Would it be possible to add bps (basis point) to the list of standard > units if it makes sense to use it ? There is already 'percent' so 'bp' could be as well, makes sense to me. I can send a patch for it and we'll see what Rob says. Best regards, Krzysztof