From: Mingyou Chen <qby140326@gmail.com>
To: TuteMthCD <matias.civadda2342001@gmail.com>,
platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ilya.gladyshev@linux.dev,
ilpo.jarvinen@linux.intel.com, hansg@kernel.org, chris@miget.com
Subject: Re: [PATCH v3 1/2] platform/x86: bitland-mifs-wmi: Fix response payload copy size
Date: Wed, 21 Oct 2026 20:36:14 +0800 [thread overview]
Message-ID: <5f8047e2-9803-451e-9a70-6b9275d4ce5d@gmail.com> (raw)
In-Reply-To: <20261020234927.121570-2-matias.civadda2342001@gmail.com>
On 10/21/26 07:49, TuteMthCD wrote:
> sizeof(*output->data) copies only one byte, leaving the rest
> uninitialized. Use sizeof(output->data) to copy the full 28-byte
> response payload.
>
> Signed-off-by: TuteMthCD <matias.civadda2342001@gmail.com>
> ---
> drivers/platform/x86/bitland-mifs-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
> index 44b16b7b4034..522b38e9755e 100644
> --- a/drivers/platform/x86/bitland-mifs-wmi.c
> +++ b/drivers/platform/x86/bitland-mifs-wmi.c
> @@ -265,7 +265,7 @@ static int bitland_mifs_wmi_call(struct bitland_mifs_wmi_data *data,
> if (output) {
> output->return_code = return_code;
> output->function = function;
> - memcpy(output->data, payload_data, sizeof(*output->data));
> + memcpy(output->data, payload_data, sizeof(output->data));
Hi,
I've included this fix in my v13.
> }
>
> return 0;
next prev parent reply other threads:[~2026-10-21 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 23:49 [PATCH v3 0/2] platform/x86: bitland-mifs-wmi: Fix TM2107 profile handling TuteMthCD
2026-10-20 23:49 ` [PATCH v3 1/2] platform/x86: bitland-mifs-wmi: Fix response payload copy size TuteMthCD
2026-10-21 12:36 ` Mingyou Chen [this message]
2026-10-20 23:49 ` [PATCH v3 2/2] platform/x86: bitland-mifs-wmi: Fix TM2107 profile handling TuteMthCD
2026-10-21 8:59 ` [PATCH v3 0/2] " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8047e2-9803-451e-9a70-6b9275d4ce5d@gmail.com \
--to=qby140326@gmail.com \
--cc=chris@miget.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=ilya.gladyshev@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=matias.civadda2342001@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®