From: Joe Perches <joe@perches.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style
Date: Sun, 21 Oct 2018 05:26:52 -0700 [thread overview]
Message-ID: <5f8063e4163361d64069d0fbecc7f723b503a4b8.camel@perches.com> (raw)
In-Reply-To: <20181020110819.1576-3-straube.linux@gmail.com>
On Sat, 2018-10-20 at 13:08 +0200, Michael Straube wrote:
> Rename the variable isCCKrate to avoid CamelCase.
> isCCKrate -> is_cck_rate
[]
> diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c b/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
[]
> @@ -71,19 +71,20 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
> s8 rx_pwr[4], rx_pwr_all = 0;
> u8 EVM, PWDB_ALL = 0, PWDB_ALL_BT;
> u8 RSSI, total_rssi = 0;
> - u8 isCCKrate = 0;
> + u8 is_cck_rate = 0;
> u8 rf_rx_num = 0;
> u8 cck_highpwr = 0;
> u8 LNA_idx, VGA_idx;
>
> struct phy_status_rpt *pPhyStaRpt = (struct phy_status_rpt *)pPhyStatus;
>
> - isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
> + is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
> + (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
It would be sensible to convert is_cck_rate from u8 to bool at the
same
time and remove the ternary ? true : false too.
As well, perhaps remove its apparently unnecessary initialization.
next prev parent reply other threads:[~2018-10-21 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 11:08 [PATCH 1/3] staging: rtl8188eu: simplify odm_evm_db_to_percentage() Michael Straube
2018-10-20 11:08 ` [PATCH 2/3] staging: rtl8188eu: rename variable Max_spatial_stream - style Michael Straube
2018-10-20 11:08 ` [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate " Michael Straube
2018-10-21 12:26 ` Joe Perches [this message]
2018-10-21 19:49 ` Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8063e4163361d64069d0fbecc7f723b503a4b8.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®