From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F72C43387 for ; Sat, 22 Dec 2018 20:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 039312195D for ; Sat, 22 Dec 2018 20:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405016AbeLVU1H (ORCPT ); Sat, 22 Dec 2018 15:27:07 -0500 Received: from baldur.buserror.net ([165.227.176.147]:41358 "EHLO baldur.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404987AbeLVU04 (ORCPT ); Sat, 22 Dec 2018 15:26:56 -0500 Received: from [2601:449:8400:7293:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gaZ0s-0000VD-Fz; Fri, 21 Dec 2018 22:35:47 -0600 Message-ID: <5f83750ca7c146f7080444b85dc58f51cc0b3b35.camel@buserror.net> From: Scott Wood To: Andy Tang Cc: "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "benh@kernel.crashing.org" , "paulus@samba.org" , "mpe@ellerman.id.au" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Date: Fri, 21 Dec 2018 22:35:45 -0600 In-Reply-To: References: <20181031065736.32719-1-andy.tang@nxp.com> <09ee2f91765add47e628e0ab03776d468cec0914.camel@buserror.net> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2601:449:8400:7293:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: andy.tang@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH 1/2 v3] powerpc/fsl: Use new clockgen binding X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-12-12 at 01:57 +0000, Andy Tang wrote: > > -----Original Message----- > > From: Scott Wood > > Sent: 2018年11月26日 9:19 > > To: Andy Tang > > Cc: mturquette@baylibre.com; sboyd@kernel.org; robh+dt@kernel.org; > > mark.rutland@arm.com; benh@kernel.crashing.org; paulus@samba.org; > > mpe@ellerman.id.au; linux-clk@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH 1/2 v3] powerpc/fsl: Use new clockgen binding > > > > On Wed, 2018-10-31 at 14:57 +0800, Yuantian Tang wrote: > > > From: Scott Wood > > > > > > The driver retains compatibility with old device trees, but we don't > > > want the old nodes lying around to be copied, or used as a reference > > > (some of the mux options are incorrect), or even just being clutter. > > > > > > > > > +sysclk: sysclk { > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <100000000>; > > > + clock-output-names = "sysclk"; > > > +}; > > > + > > > clockgen: global-utilities@e1000 { > > > > The U-Boot fixup won't work with this. U-Boot patches the frequency > > directly into the clockgen node (BTW, this is another reason to preserve > > the generic > > 1.0/2.0 compatible string). The new binding does not require an input > > clock node when it is provided as clock-frequency directly in the clockgen > > node -- and the sysclk node was not in my original patch (nor did you note > > that you made changes from that original). Why did you add it? > > > > I would just remove it when applying, but I'm concerned that this > > indicates > > a lack of testing (and I don't have the hardware access to test it myself, > > except on t4240) -- unless the 100 MHz sysclk just happened to be correct > > on the machines you tested (which would also be a test coverage > > problem)? > > [Andy] You are right. Sysclk may not be useful anymore. > Uboot will fixup the clockgen node correctly. Please apply this patch > without sysclk. We will > test it and catch the error if the clock is not fixed correctly. OK. > BTW, which git tree are you going to apply it on? This one? > https://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git/log/?h=next That will be the branch I use to send the patches to Michael, but it's not a branch that is kept constantly updated. If you're asking what tree to base future patches on, that would generally be the next branch of powerpc/linux.git (unless you depend on something else that isn't there yet). -Scott