From: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v6 05/13] arm64: dts: qcom: x1e80100: Add CAMSS block definition
Date: Wed, 16 Sep 2026 23:36:50 +0800 [thread overview]
Message-ID: <5f8746bc-392a-42c3-8ca2-07327e5651ea@oss.qualcomm.com> (raw)
In-Reply-To: <6ca6cacc-3fcc-4d1d-a6cc-cdc1e9a403ca@kernel.org>
On 9/16/2026 10:59 PM, Bryan O'Donoghue wrote:
> On 08/09/2026 09:46, Wenmeng Liu wrote:
>>> + <&camcc CAM_CC_CPHY_RX_CLK_SRC>,
>> I think we should remove the SRC clock.
>>
>> Thanks,
>
> There's no clock that is derived from this clock, so if we remove it,
> what is responsible to switch this on ?
This SRC clock has child clocks such as CSIPHY0/1/2/4. The CAMSS driver
never enables this SRC clock directly, and enabling the child clocks
will automatically enable the parent through the common clock framework,
so the SRC clock can be dropped.
Thanks,
Wenmeng
next prev parent reply other threads:[~2026-09-16 15:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 14:20 [PATCH v6 00/13] arm64: dts: qcom: Add x1e/Hamoa camera DTSI Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 01/13] dt-bindings: media: qcom,x1e80100-camss: Describe iommu entries Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 02/13] dt-bindings: media: qcom,x1e80100-camss: Make vdd-csiphy supplies optional Bryan O'Donoghue
2026-09-10 8:44 ` Krzysztof Kozlowski
2026-09-06 14:20 ` [PATCH v6 03/13] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2026-09-08 8:44 ` Wenmeng Liu
2026-09-06 14:20 ` [PATCH v6 04/13] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 05/13] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2026-09-07 10:34 ` Loic Poulain
2026-09-08 8:46 ` Wenmeng Liu
2026-09-16 14:59 ` Bryan O'Donoghue
2026-09-16 15:36 ` Wenmeng Liu [this message]
2026-09-16 15:48 ` Bryan O'Donoghue
2026-09-09 12:46 ` Konrad Dybcio
2026-09-06 14:20 ` [PATCH v6 06/13] arm64: dts: qcom: x1e80100-crd: Add pm8010 CRD pmic,id=m regulators Bryan O'Donoghue
2026-09-09 12:40 ` Konrad Dybcio
2026-09-06 14:20 ` [PATCH v6 07/13] arm64: dts: qcom: x1e80100-crd: Add ov08x40 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-09 12:43 ` Konrad Dybcio
2026-09-16 14:58 ` Bryan O'Donoghue
2026-09-16 15:04 ` Konrad Dybcio
2026-09-16 15:06 ` Bryan O'Donoghue
2026-09-16 15:14 ` Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 08/13] arm64: dts: qcom: x1e80100-t14s: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 09/13] arm64: dts: qcom: x1e80100-t14s: Add on ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 10/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 11/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add l7b_2p8 voltage regulator for " Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 12/13] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-09-06 14:20 ` [PATCH v6 13/13] arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8746bc-392a-42c3-8ca2-07327e5651ea@oss.qualcomm.com \
--to=wenmeng.liu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®