mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Deffontaines <vincent@gryzor.com>
To: Sean Young <sean@mess.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>, <linux-serial@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Alan Cox <alan@linux.intel.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH] tty/8250_pnp: serial port detection regression since v3.7
Date: Wed, 06 Mar 2013 15:42:29 +0100	[thread overview]
Message-ID: <5f8a2a7219eccbf1a848a774635d9ec2@raceme.org> (raw)
In-Reply-To: <20130304132839.GA6965@pequod.mess.org>

Le 2013-03-04 14:28, Sean Young a écrit :
> Greg,
>
> On Fri, Feb 22, 2013 at 04:27:19PM +0000, Sean Young wrote:
>> The InsydeH2O BIOS (version dated 09/12/2011) has the following in
>> its pnp resouces for its serial ports:
>>
>> $ cat /sys/bus/pnp/devices/00:0b/resources
>> state = active
>> io disabled
>> irq disabled
>>
>> We do not check if the resources are disabled, and create a bogus
>> ttyS* device. Since commit 835d844d1a28e (8250_pnp: do pnp probe
>> before legacy probe) we get a bogus ttyS0, which prevents the legacy
>> probe from detecting it.
>
> Would you mind accepting this patch please -- it fixes a regression I
> introduced in 3.7.


Hi Sean,

Thanks for the patch, and thanks for re-pushing it :)
This is to inform you that the BIOS update referenced :
Version: SC24 BIOS V1.01
Release Date: 01/11/2013

Seems to fix "my" tty detection problem on 3.7 (tested on a 3.7.6 
Fedora kernel, with success).
I don't think the patch will hurt anyway - I believe it still will 
prevent other users from a regression.
I also confirm that the patched 3.8.0 detects its ttys fine on a 
BIOS-updated system.

Regards,

Vincent


--
Stop chasing shadows, just enjoy the ride
Morcheeba


      reply	other threads:[~2013-03-06 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22 16:27 Sean Young
2013-03-04 13:28 ` Sean Young
2013-03-06 14:42   ` Vincent Deffontaines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f8a2a7219eccbf1a848a774635d9ec2@raceme.org \
    --to=vincent@gryzor.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sean@mess.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome