From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257BCC54EE9 for ; Wed, 14 Sep 2022 03:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbiINDPx (ORCPT ); Tue, 13 Sep 2022 23:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiINDPt (ORCPT ); Tue, 13 Sep 2022 23:15:49 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FA91EC40 for ; Tue, 13 Sep 2022 20:15:48 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so17512802pjq.3 for ; Tue, 13 Sep 2022 20:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date; bh=Hn4otagjumTw49USqUIv3aIESk39vSQ7nnrygHJA1RM=; b=Vv9q+dPE9Xt5hHPzis7fhX6kTsf1B9KGILvS9Ojq8U83fKBRmcuLAytyV2QPlwV4tm MxpCRzVvZOssnaXJZTjzUkqHQH6yPnaveU6FhJbYJm6NpNT3QwkJVx7cf8FMhTkZA5Dm nhXfarzfZC6Znu6jC8Q0FDXbCGV4vUa/bhcRXTIm4dskUe1cyzsInw23LNouaKzJuk5q tDzVCXjJkHoH1GgOKoRX7sPPHBjxq9j8JkBXCp3N6Dh54w4qgoGEYFB4TNxUh/I8wC4x cL3LeOT+MZ6xG7drZQmcK+eWC/ZVnbCSJX/C5Nje3JACRZB4GOGqC4K69NyWKizP0/Rq OleA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date; bh=Hn4otagjumTw49USqUIv3aIESk39vSQ7nnrygHJA1RM=; b=P0hDwaVGGezav06vvXYew/hfFP2Dd3CF9WnhliVkeiE9yl92fBNV9yyU4LxQX0Nt7u WZPkfqiYjWrQ8Uk66KyNoCpAORAZxTr6LIJhPjeyXSigX2JB57+x0lsLC00eGSIZquMz bv27/ImKmnX/gxC4fEjgBMlEgMlUNkGz3miTiNCwLP9x6zHJgFzVo3H/lbLDDMkDFl0E fsMji2apiCDgKqVxiS2/2xqGiqdFCikZNoMtfres/RGwCFVCq5MDJzpFEBJ+IsQSiQGJ sJDzKUp9wIOUn9N0qV7YkjIesVDsCdE11cWZIDXaRcIZ54SnDLV0Tq0VjYRSnnSprgqr CTvA== X-Gm-Message-State: ACrzQf3gButAj7EWUUTWYlf8H8J70JMaDG65CL1ZFNg1D50Y7z2B+GiA AohF3mqNZUYVT8xpMRb4Hmlj6Q== X-Google-Smtp-Source: AA6agR4iw+NO6u+3snYgXRblqsQGkidXfNUi9Nmx0V/cbz6vyRNOEyx0KNTnzX+8/hoiCWT8wAx52w== X-Received: by 2002:a17:90b:314b:b0:203:41c:2dbb with SMTP id ip11-20020a17090b314b00b00203041c2dbbmr2496401pjb.18.1663125347919; Tue, 13 Sep 2022 20:15:47 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:427:1cff:3226:873b:1ccd? ([2400:8800:1f02:83:4000::9]) by smtp.gmail.com with ESMTPSA id o22-20020a17090a5b1600b001fd77933fb3sm8133364pji.17.2022.09.13.20.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 20:15:47 -0700 (PDT) Message-ID: <5f8b9a15-ec53-127b-63c3-b32005b35e05@bytedance.com> Date: Wed, 14 Sep 2022 11:15:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [External] Re: [PATCH V2 2/5] erofs: introduce fscache-based domain To: JeffleXu , linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com, huyue2@coolpad.com References: <20220902105305.79687-1-zhujia.zj@bytedance.com> <20220902105305.79687-3-zhujia.zj@bytedance.com> <56b0a8c1-94ce-3219-6b43-d91d2e0e85b5@linux.alibaba.com> From: Jia Zhu In-Reply-To: <56b0a8c1-94ce-3219-6b43-d91d2e0e85b5@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/9/14 11:02, JeffleXu 写道: > > > On 9/2/22 6:53 PM, Jia Zhu wrote: > >> int erofs_fscache_register_cookie(struct super_block *sb, >> struct erofs_fscache **fscache, >> char *name, bool need_inode) >> @@ -495,7 +581,8 @@ int erofs_fscache_register_fs(struct super_block *sb) >> char *name; >> int ret = 0; >> >> - name = kasprintf(GFP_KERNEL, "erofs,%s", sbi->opt.fsid); >> + name = kasprintf(GFP_KERNEL, "erofs,%s", >> + sbi->domain ? sbi->domain->domain_id : sbi->opt.fsid); >> if (!name) >> return -ENOMEM; >> > > What if domain_id and fsid has the same value? > > How about the format "erofs,,"? While in the > non-share-domain mode, is the format like "erofs,," or the default > "erofs,"? > Thanks for pointing this out. I'll revise it. >