From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Harish Bandi <c-hbandi@codeaurora.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998
Date: Mon, 1 Apr 2019 18:16:18 +0200 [thread overview]
Message-ID: <5f944a7f-976d-bc16-3f07-d65d0aecb732@free.fr> (raw)
In-Reply-To: <1553689723-21017-2-git-send-email-c-hbandi@codeaurora.org>
On 27/03/2019 13:28, Harish Bandi wrote:
> +bool qca_is_wcn399x(enum qca_btsoc_type soc_type)
> +{
> + if ((soc_type == QCA_WCN3990) || (soc_type == QCA_WCN3998))
> + return true;
> +
> + return false;
> +}
Dunno if you saw my earlier comment.
The above is not very idiomatic. I would write:
bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
{
return soc_type == QCA_WCN3990 || soc_type == QCA_WCN3998;
}
Regards.
next prev parent reply other threads:[~2019-04-01 16:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 12:28 [PATCH v6 0/2] Enable Bluetooth functionality " Harish Bandi
2019-03-27 12:28 ` [PATCH v6 1/2] Bluetooth: hci_qca: Added support " Harish Bandi
2019-03-27 16:46 ` Balakrishna Godavarthi
2019-03-27 16:56 ` Matthias Kaehlcke
2019-03-29 4:40 ` Harish Bandi
2019-03-28 21:05 ` kbuild test robot
2019-03-28 21:23 ` Matthias Kaehlcke
2019-03-29 4:42 ` Harish Bandi
2019-04-01 16:16 ` Marc Gonzalez [this message]
2019-03-27 12:28 ` [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998 Harish Bandi
2019-03-27 17:29 ` Matthias Kaehlcke
2019-03-29 4:38 ` Harish Bandi
2019-04-01 12:39 ` Harish Bandi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f944a7f-976d-bc16-3f07-d65d0aecb732@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=c-hbandi@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®