From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756692AbdESUcV (ORCPT ); Fri, 19 May 2017 16:32:21 -0400 Received: from mail-by2nam01on0042.outbound.protection.outlook.com ([104.47.34.42]:43405 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750943AbdESUcS (ORCPT ); Fri, 19 May 2017 16:32:18 -0400 Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant To: Corentin Labbe , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "Lendacky, Thomas" , "boris.brezillon@free-electrons.com" , "arno@natisbad.org" , "matthias.bgg@gmail.com" , "giovanni.cabiddu@intel.com" , "salvatore.benedetto@intel.com" CC: "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "qat-linux@intel.com" References: <20170519065331.27670-1-clabbe.montjoie@gmail.com> <20170519065331.27670-10-clabbe.montjoie@gmail.com> From: Gary R Hook Message-ID: <5f959f00-ca3b-0515-d743-33b251fb4b18@amd.com> Date: Fri, 19 May 2017 15:32:09 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519065331.27670-10-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR14CA0003.namprd14.prod.outlook.com (10.173.227.13) To BN6PR12MB1316.namprd12.prod.outlook.com (10.168.228.10) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR12MB1316: X-MS-Office365-Filtering-Correlation-Id: 36692a6e-61eb-4474-4c00-08d49ef62342 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR12MB1316; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1316;3:cdaPGD8P0Du+3VsTzhKRZWxd6zNZEXgVEQN75N7g9YqlREWBRuO26TABOXkHFj2caoEEi7TeLIaM2vh5cnh6d9+NqzNO7Aun9EQn5nB++4bUmR3GPq6lir892XHcL9ookLTXOabg9/g+uKOQfE69BqCBK6kZ4fTzFyhyG2/nyJfAUgbG0JFtl5lNL7ZleOn7YMhfW7oS38xWvG7GIYWUUxO7AZCQIntO+u3zHz2fIHHzUzKwU3tvow676sHQy+q6dK7Y8fNXyISBpt/2Hl8QIpYySc3jqba6gp1YlWKmQWSUMaqrxoGZWsReQ5f/EgFJq5azXeqGn8mQiSEq1pVH+mWFIhqKCw+dYXWmhMVAbw0=;25:3BlYkNRVJQKgyKLSmLmHrZZ/H0Rv9KwFhOxU/ND9tLjjz/4ky5BaD09B1soVcZs9ldQg5pn4K5g4IXy66U0BiohW6YDAo50P4iG+0fX6sYraCBnNn7K+dY9G3rJ/LFw/2i8qqduPbH7FEyqaFElbIMFCch7rvAro6QzSiKMhgFMnki4shLNIbKX8HV/9Ck+ncwCBytYGC+q99xsFcTmXGIY1WHqMqOWIInfmGWIWuc8PzTnxQjqOoqe8yxlxyCP1EzWCgA1CaAtPjwI8qxmnmrJoQffRL3SfpTniuOz29sMLFmyj+AhWAu9qNiYTMfgRhJ1GWguiVoolGfYiBalX4FS4y4QxD3SWJlkNwbXcmojpY8WF156BekjQsMYdjidRWamqD76lAAQfndxt4lkLK4fKL1AWTjOMybhaz174I0Oi8TSGamQNRaemwft3JuiBMcHcsZC2f8d3ReO5YCCa3NV55Tw+FUp/nhEmczCIsyo= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1316;31:btDTIcbu4Bcgi1amCdf2UUYJ3OkQ4ejZ6XzP0idvgiTdZrobk0uq/s6Rmy9+Qqha0YjSGztLJKb4DduzIbsWWc5NWf4zl8KoFsJouPJlZ1O9MFd4KTSqgaWObvBEaCj1Jq5AjVk2KohNY7oPqEtUpvlW+JiE2PNRHO+MF3yXDsVMglUKoqiFJDm469ly8Q0tPlW6DooG/vTcKM5J3o332fFmnMZjsdD7w/AwUiIZXXo=;20:UpqW136Ie5+O9sprwqgCV/LTKiAHGgnTGM9UVErpucKQ33633XBLGQTqlWy5Dsd6b4FePzf2xTBdSfnQqd6Hnt2D7AQDFSe+WB0h+KUhaFkVs676pNdBShVwtcxOuzZts13NF0M0ggUa19kdCrMeYuTi/ZuMQ/maFc5WI3GANfC5nxES0zLOZ+1lhZy+oMoLDRcG3vcBUkqJ60MnYh5tIt7a4ZPtpcfUOKtqcM1Tgnf6N/zhcm0auLSO77LZIM2/HK8Wh6sWfj50Vb3cotxKjGhkDvNBd8LwMrkC14O7D9+8TKJAyCH177kToh8ErzIeuH+5UW2M/K+VKrl/7a27F75R1H9gxovy+Lu+GEBiCXzBDbl6ulYkQRR71T7acAQxa9KNbd+K5BVWdPfZXZ82smS3vLacc1JG1AXRKiD5Yri9qdqHzmHWaE0u3c+dKG8j82rhWzSnTXc7OdaKm31HpGbGH+Yqp4OSUtowUA+d5Z86YwjLjH/rR6l2eAKjIVn6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:BN6PR12MB1316;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1316; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1316;4:xC1/jBwxKVOKOCNkctS2Aa0rQqGaj3yEx5STH8WUzW6NnnYthTq8tAL8X4vFWKBcpFXM2tjEY262PMi7zo9LbQ0Y/GrMULcvB2wEcZKW9UHgqt3KyO37dXxN/iKDqc6oVeP8gOkbi6qtt74d0WPiprDXy2BBnu/TiWBZukSXLm5R9R25Sv91JKjIqH26ifGAVaosOzLgzondDnRYJsWU+prU+H41IgMqgUypqg7xmjCYZNkVGFfDqPqeXIOiCCWXBJLuxnahxKzBY3MjFx8GOUVScw5OSs6Vy8L6/IToi5Iza773fNEoG0fDjC+EghvXrcfMmiPCFaIb19ioMWTjYRyLKiyEHi+w1TTSOceOCMcFdvYL29xCAHM9P8odo0eAUvQYDH7wRuLnLA98bmPUFYrwHqGxMJmc1ys1YjiEZ5G+70EijuPKfqwBHLjyDxTwwZcEvq+lwB4ZrQzxK2ciPZaHXNwxa3GlXZSjDiro4VHIfwIjveYcJDkuNYBIJgxgAhokU5OK7McsFq1lIuB8cz9KG1eqZe5hJXo6XVREVRkBnMrJB6vhprUTJESJF31ioSf1Mtt1sZBV79Bwc47DNf3PmevT5H+2mF0gY4grYeROPuVN1mm7U8IQ9HGk9Z6xyF/Bqa/qyVPtCO8tMgTPvDxAaEtv2ucDdu/usV7erxE1uOMXkSOONgYlJk4NsENVQZHXDUUWJP5W7Pt+viXYw/NyXbFWY0pT/GQABVP7GVP+YvTacsbQkXfeDdtH1LxshB45F195Z/SS1z76jhCFyTtyvnM4zVg7gezgXBCxx2VIdG10hH9EOOV8Z4JdFxebRtVd5zSF93EuC7seWihEwhzBiuPeAtHik8fubc8fTaU6c6UfdMEndCSlj/8iV+tl X-Forefront-PRVS: 031257FE13 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39400400002)(39450400003)(39850400002)(39840400002)(39860400002)(377454003)(24454002)(50986999)(76176999)(7416002)(54356999)(230700001)(38730400002)(23676002)(6246003)(7736002)(2906002)(6116002)(5660300001)(305945005)(65826007)(2201001)(3846002)(33646002)(42186005)(4001350100001)(189998001)(50466002)(31696002)(86362001)(31686004)(65956001)(229853002)(66066001)(47776003)(65806001)(6666003)(3260700006)(2950100002)(53546009)(478600001)(2501003)(25786009)(36756003)(77096006)(6486002)(8676002)(54906002)(81166006)(72206003)(4326008)(83506001)(53936002)(90366009)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1316;H:[10.236.18.126];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMzE2OzIzOi8xUSsvckZSSER6cmw3RmVKUzRuOGkwQUx1?= =?utf-8?B?Vm5rVEV1WlhuTVVNeFhDZFZoVEdkL3pqUTVUVmVkbHEwTy9BKzlBVjJhTHJr?= =?utf-8?B?MlM5K09WaWFYOGRjL2lvU3BEUVE2NFFjN1pBbHJ5MDhQVTZtMHVES0Y5YmNX?= =?utf-8?B?cXA4bVUvZkk0bEJtc095OGNZR29PV0pZbnJGZ2lockw0T1A1NEdDeUxpdmZD?= =?utf-8?B?NDkrMU5tazY3MmJ2QlV2UEx0M3UzdGd6WHU0b1BFbUd0V25UeW9vR3c4OG92?= =?utf-8?B?eWpYZWlvQ0pUVklLQXhBUUhQa3lJeWliWFhZRE95OGZkNW9VaVJTbTg2WUtR?= =?utf-8?B?NkFPN0g0SEZXUnk0dWVpQnJIVUprdWV6M213MDA0Q1h6QlIreDllM2RWcXFr?= =?utf-8?B?UVRMK0tsaE5KZEN0NzFWYUVsMC9tdk1BUTVnbEFhRW8rN3VTNHY0dzFzQUN5?= =?utf-8?B?cWRCVS82dmNwZzREcVkyZjF3MDVSQmpFaVArd08vWWpJU3JYNmNVV2ZzZ2dO?= =?utf-8?B?c0dLUXFxYnFRdGtvNysrLy92bGJPVnpCUThWdUJETnRQRVZmS1l3SFZIam40?= =?utf-8?B?dWY2elY0VkM1NU1LVEQ1eEw2d21BRTJKL1p2S0tzLzNzV2VybUs5SVd6Z0VD?= =?utf-8?B?S09TTUdocFZjZ1JHNDBGUDhUeDBKbUtWL2YvZ0RLVkxBblJBeElna0pCZzRH?= =?utf-8?B?d0tBSHcySnBMcERXMnZXekVqTWZQMHpDRTRSSlA0UmhNOUFFcDlTTFNjS09M?= =?utf-8?B?ci9DQTZ0UkxkWkQwUDZhOXRFam0yNndQMEhlM1FmYzdzS1RJT3k0bXVoZzEr?= =?utf-8?B?YWNrdzFWRm9rYStnNGw2VWlGWC9CU0FmTkR3YVJOYTZ2eEtKcUZwaXhPcVpP?= =?utf-8?B?N0kwMUhnWEw5cXhnNHNXTldlejNpVVNCL0oxYnRxS1ljMGxnb1ZYOWdLV2ZV?= =?utf-8?B?TzQ5Q2wwVkNtL2RxNVEwM3NnRUFQMkNwN05YSi8xUDNORkVFSzJBQ3FIYWg2?= =?utf-8?B?NU5PZmZxdndqaGZKZkxGWDE2aVVSNlFWc1lHRndDemR6TnJRbFJTRGxyWXhK?= =?utf-8?B?VUYrelhLbCtoYlJBemNmUFc5aE43QmNrQmtXN2Fxd2Y3Q05HaCtxRnFUMVNv?= =?utf-8?B?YnVoMU44K20xcjJHbVdjaUJBQzh2bzZnaE5YOGRBVmdhdVo2bzE1cGY5K2R5?= =?utf-8?B?RlIzRWtkVmpFc2hSV1Yycjh6alpJNldsaFRKaVhUc1Zja3pqSGFOalZPMC92?= =?utf-8?B?NStVUHEwelVQUlpWcklENU5JYWM5TUJsa3FRdzhCSmJMbUozYnJIanFlTGxT?= =?utf-8?B?UE1CaGFlSVMrdGZieVh6dHBJYitEQTBVbHROTC9rYWZjalhyVWtVOW93ekpS?= =?utf-8?B?aU5EV0lIM3FBZk1SQXBHbU9Qc2dhVm9Ganh4eGFCcFZtVS85QU5SVEdmcDRi?= =?utf-8?B?UVVUT3NQZlRRdUh0dWh3bFBLNThTTTVMdmZDUnA0ai80dTNDR0p4ZGk2SFI4?= =?utf-8?B?RHRsc3VBVzdBMjJNcUxOL2tmYUVDZlc5T2NNamRhOXBaRkJneXh3LzZzdi9p?= =?utf-8?B?YkJDcTEwVERaRTE2dE52T3pha2FKZ1VGTmQrTnFFSVdsMGlwcE54MncvZW9u?= =?utf-8?B?KzBtbnZiWE81SHhoTE90S0l1bWNUVVRFYzhyS252dUVaVHlXSmZzTXhGc05V?= =?utf-8?B?OHhiT3BjbXBnNW1hMHpra2xFQ0RkRWhsVGU3eThaUXRVR3dRRklXWldFZ0dB?= =?utf-8?B?ZG9lc1pwcWhLTXIxY3c5M0prbGpSNGU5U0J2MndXQW9WQy9SbUxxa3hjUlly?= =?utf-8?B?UnhIMXY1dTBWd21JbEFuY3F4ZHJFYmV6SVhmeURZdW9GbmRJUEJWczFWRDlx?= =?utf-8?B?MU5XMFRCcWVCVWNEWGc2dEtGNGJPRlpLSjlEK2ZGeUxpSWx2VHRURjAxR3dD?= =?utf-8?B?NXJCSGFjMmd0M1hqWEZER043bnFLV3M1T3JEMEp1ODhmQ29RYjNHU2h5ajRN?= =?utf-8?Q?qhEp+n?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1316;6:cjsA2WBjToYuaz99QKvWTucXYxhludCfeXEJelZ94KiV/+60jxPnUFNjQ+raX/347acTjVLG9qH9MBYQpnIFXPJCPuIvi2WjQuuIJlMduxRueP+6J8vOc1v1RAAYz+VJFku30tftHuNkhjf/Fnop+MVqHVQ9ODrORbeMtQ7U/s9aQoM/rx4TAeLErxlRt0cUhhyECVRClzp2Acu3qNhQynyd99NyXCHCBUwAUxoQ9LcsErPHiCUEvDYCAI7kw6rX5spV6SpI5jer2nPVGf/r+MQzOaMDJ9nYCiTD4Ol/x2SFSMHY4howlUt2F36bVmyJCjxLcKcipKfLPjHL16ADXgQ5vuv9fjFEWaNDz2A56v28BntC6SbqGkupqW9C+vwKwTlxv9rNquQnsSt+FJLoFYQLb/ZM7zUwUi+ECXSvN6XXy/e+/hUslTHGrHo57smlHIZ0ycEONXf6BelSnyrXHT3xPGY+kTqt/6++hXr/q2qqP/apSTDAHigWVZzuR2AXViRKbDAzsgJjligyXK5tGEVcMxPVzrDj39bltrQoo6U=;5:/Brba3ZqWuMoH+whMsBfvEXa3ZBaEB/wfNRyveeW/3q1Tf2OlgtnKVIC3dqAPJKlKTbikTV3lbr9qCHn71yu13QhGQi7iVGNNVp7aERFdkkTQ1roCauhyvbVmmRqNrngTifE9ah/Ks9lDpoutX6jyA==;24:xCcgUmqefX506gls4rVgAiM85cY5gAThJ1i9JrQuypdeWHP8sxk8kMBRclyzlQ7zhk/nVWaSQsnRWuxbCV1v78gMl9JRdbT95C++uKuDCy4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1316;7:wlqmvitJi4FZl8KC7Lle1gJJu5ACMR8Mew35xjCp8MtvMfx8DsMwGUJT7YJwzE9jG1CCHjNDHra1q699IyOE3dnYiAryjW6KKad11YGoNPDTYT8Bt41uW4LI9k9Hc/tvEevfRD8yfpYCpInneuQI94K3j9FgY8y+lwfZl5im1tna+nT1oioSHl/pozWKZ6vw50Ay455bxwBo3SGrD1cCfSzQ28TUZwJR6yGgB18T62G/U7eW5sglqfkwhmfhkUBzS4760I9Q0PwOQOHYGTxlCWopHWP3ALDgHNX///HloyfsXhy87HVmu1SC+ZT7qJhZGkUjbAcLZqQ2vpuhw2bXvw==;20:LfI4XgRLPp1CVrRRYZk1oGJwGW13v3cjd7w85/IQ0DCOKZDBldDxQswh86cJb2PeKZClBp0Wnn0GtiWonspHXMC0b1ErlYbSCEw5MwAYGb13kVWNjZ26VRL8ZTw2N5jlKtLQV3FK5+QO9mFG4TpY/AjEbj5AXsHtQbtRuVMFef5pw2afZEtpafj1b4tkGS+Dp95Qyqy8W3cUoJJWdWynykwpUkp87ezYvn/H3qghhsQGKnHjmdeGIF246zJq4Z29 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 20:32:13.6926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1316 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2017 1:53 AM, Corentin Labbe wrote: > This patch simply replace all occurrence of HMAC IPAD/OPAD value by their > define. > > Signed-off-by: Corentin Labbe Acked-by: Gary R Hook > --- > drivers/crypto/ccp/ccp-crypto-sha.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c > b/drivers/crypto/ccp/ccp-crypto-sha.c > index 6b46eea94932..ce97b3868f4a 100644 > --- a/drivers/crypto/ccp/ccp-crypto-sha.c > +++ b/drivers/crypto/ccp/ccp-crypto-sha.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -308,8 +309,8 @@ static int ccp_sha_setkey(struct crypto_ahash *tfm, > const u8 *key, > } > > for (i = 0; i < block_size; i++) { > - ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ 0x36; > - ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ 0x5c; > + ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ HMAC_IPAD_VALUE; > + ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ HMAC_OPAD_VALUE; > } > > sg_init_one(&ctx->u.sha.opad_sg, ctx->u.sha.opad, block_size); > -- > 2.13.0 >