From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C9FC48BC2 for ; Fri, 25 Jun 2021 17:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C5796186A for ; Fri, 25 Jun 2021 17:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbhFYRWi (ORCPT ); Fri, 25 Jun 2021 13:22:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46471 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFYRWh (ORCPT ); Fri, 25 Jun 2021 13:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624641615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tUgH0GOkQfIIk3JfpZs9t9DVg0sOfkCdzi/tS1XtQpQ=; b=Tw+HM0l/etauloLsZlCIx4PFPVj8C/IfNHy8WgaXZzNpaNkvuLMwVqcIGK6YumCcUqkU3b mw2y0iSCgKrSXKwmpWBhiny8jqPlZeiAzreWHDZELPvsAFyAMp9BZCh70Z6jTV3e2wlzbj cISM/5TbemAuyprv92OSXzf/s6JQxNs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-BT3GVNzSMTy5kvRiFmr7ng-1; Fri, 25 Jun 2021 13:20:14 -0400 X-MC-Unique: BT3GVNzSMTy5kvRiFmr7ng-1 Received: by mail-ej1-f71.google.com with SMTP id lt4-20020a170906fa84b0290481535542e3so3363209ejb.18 for ; Fri, 25 Jun 2021 10:20:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tUgH0GOkQfIIk3JfpZs9t9DVg0sOfkCdzi/tS1XtQpQ=; b=BrG0cK2iZbaYJfCFtxL1Nx2w1tlDQ8UmpPdHxPo7tAhYU9hE4cWljm8VHZkPumIafX i09/OtyWFe7EYleVXQs7sk3lIL2temYuzgjrngsogFiOOCdh2f+DHJU2L2Kbh1CEfblG cG2Aql+GjPJj0yU6TcKnjTogYRC2D93No7tuKd5qxuXKLp6yuRsIiVeRLsICYTXQge6y NtJwrjVQyN49e5xrPt4lnKBB0iSBdg5Mr9NdFQkE7FXqcJUe6L1jvTZN5Es2PggDA3Ua rPvHsDhFWL6Z8hb0lrZVilMw0ljdxxn8MvXmjLnw8Ws729oWu5Dqp4MXSUcw5Zgl6vBy u2gg== X-Gm-Message-State: AOAM532UBh7rbK+sFAYSXhGxkChdAxG6XiOjSlzPpdLAU6Ion/3sXq/k Zo/sw77i521R6VrfLqnputMA93Q5w6e8aVnHTqu0BUg+HaZvtDTX5XHuUD/g5p+aCNUpv5tavRB boQISXw2lqVEcq6v1QoREY+wevnBbNnyzwvvak/fUfne9SubZxUzDjL+MB5XoSBYc8dg6gIeZi/ l5 X-Received: by 2002:a05:6402:27ce:: with SMTP id c14mr16022013ede.118.1624641612731; Fri, 25 Jun 2021 10:20:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZalEKvLpoVAX6L+WYwpJ7UlqlSdKIkSiS8ytC1UpZNEtc3ss1rUo/OpRV/BL2iZeVSDq3nA== X-Received: by 2002:a05:6402:27ce:: with SMTP id c14mr16021990ede.118.1624641612560; Fri, 25 Jun 2021 10:20:12 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id w10sm4294282edv.34.2021.06.25.10.20.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 10:20:12 -0700 (PDT) Subject: Re: Question regarding the TODO in virt/kvm/kvm_main.c:226 To: Hamza Mahfooz Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <2ZR8VQ.IJMS3PQLNFAS3@effective-light.com> From: Paolo Bonzini Message-ID: <5f9d355f-cfd1-d85c-b186-27e7ac573ad9@redhat.com> Date: Fri, 25 Jun 2021 19:20:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <2ZR8VQ.IJMS3PQLNFAS3@effective-light.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/21 07:16, Hamza Mahfooz wrote: > ping > > On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz > wrote: >> Would it be preferable to remove kvm_arch_vcpu_should_kick or >> kvm_request_needs_ipi when merging them. I ask since, the last time I >> checked, both functions are only used in kvm_main.c on Linus's tree. I think none, the logic have changed enough that the TODO is obsolete. Paolo