From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758320AbdJMND7 (ORCPT ); Fri, 13 Oct 2017 09:03:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52728 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758144AbdJMND4 (ORCPT ); Fri, 13 Oct 2017 09:03:56 -0400 Subject: Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, maurosr@linux.vnet.ibm.com References: <20171012222153.24905-1-gpiccoli@linux.vnet.ibm.com> <87fuantpdk.fsf@concordia.ellerman.id.au> From: "Guilherme G. Piccoli" Date: Fri, 13 Oct 2017 10:02:58 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <87fuantpdk.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17101313-0036-0000-0000-0000027B8379 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007891; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000236; SDB=6.00930550; UDB=6.00468445; IPR=6.00710817; BA=6.00005636; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017525; XFM=3.00000015; UTC=2017-10-13 13:03:04 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101313-0037-0000-0000-00004210E2A1 Message-Id: <5f9d3902-5982-7ea6-951f-10f2b90d00b4@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-13_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710130181 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2017 05:37 AM, Michael Ellerman wrote: > > I really dislike this. > > You're basically saying the kernel can't work out how to get a device > working, so let's leave it up to the user. Oh, it was never my intention to say such blasphemy :) It meant to be just a debug option to help the users, specifically the ones debugging drivers, to try using a hammer to recover bad devices! To this issue that I mentioned as an example, the fix specifically goes in the FW of the adapter. Anyway, since you really dislike it, let's drop it, no big deal! Cheers, Guilherme > > The driver should be fixed to detect that the device is not responding > and request a reset. > > cheers >