From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5388CC4332F for ; Thu, 23 Sep 2021 16:23:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36B3C60FE6 for ; Thu, 23 Sep 2021 16:23:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242300AbhIWQYm (ORCPT ); Thu, 23 Sep 2021 12:24:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49363 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242124AbhIWQYS (ORCPT ); Thu, 23 Sep 2021 12:24:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632414156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YZm+wiesYVl7zMhS5rKD3EUk7Pvh+YAy8H59fwCRfig=; b=cBN/tT4OF8yuqnK67DEQfHn3hsNPHvIy2MYvOXvoMmnVttajDDuGdQkdp+dpY04K/mQBB9 3HXQI+tMw0UTvIEPqSs08p3vKX4nuW0eM4UyxGnXYR47MoFvSk0+B4OlIP2s0R2jQIluvF Jl40AEEIgd+wYFmlWLf6vv48UId5kAQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-U8spAohQMyq46_1ssyjfag-1; Thu, 23 Sep 2021 12:22:34 -0400 X-MC-Unique: U8spAohQMyq46_1ssyjfag-1 Received: by mail-ed1-f72.google.com with SMTP id m20-20020aa7c2d4000000b003d1add00b8aso7370555edp.0 for ; Thu, 23 Sep 2021 09:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YZm+wiesYVl7zMhS5rKD3EUk7Pvh+YAy8H59fwCRfig=; b=KCyuwK3PsYDLYFdh8/Qj/2ZfigN1Hqn77j9DvWP1azAzHruDaVfV9Q7GHKhTlex8es Ad5Xut1yhcxIOjPnfucv46/bOtrkw7msgDJFG6bWhPEC6xybQURmW36IBuswuzT9mcm8 4MwDUsv/mcrXOix34Ede0YbgGHqq9fagZcXSw3ed/4X+hnwvOAjK+fPVCZNqwPMX5rvX 7FRaWf9SukP4BHjTX48I8TFLkrJ1JSVLMYpc30XCM2nUcCV9DJ1whk73HN1SZRJKr/3v 5+l9eSSrrVQFr6IdYSuhzTu9re5G4C3joIcPAlf7E2xpm3IyV9DmLk+4XY/I+RbMIuV3 ExFw== X-Gm-Message-State: AOAM533oA/wXE7IqnKOY/6ePAgHVyCgCCod5fC10oK6nHCAwLpanWblx swSmIFq7kP2MaMciIoFgsi+iBqJyO+QBKHWjpWtXlDpuRf5vYhf9ufb/XcKHY7FxC4ZT/toF9v7 S82hNhB7yN/N9BDPbNj2QcLkz X-Received: by 2002:a50:e188:: with SMTP id k8mr6673658edl.119.1632414153543; Thu, 23 Sep 2021 09:22:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygd+vg/0b6mTm+/Xz8NPYPMcxf/ymptn1I+uzbwtmBaVt7SEm1YHMnao7pvB3Z1JVD4JBpRg== X-Received: by 2002:a50:e188:: with SMTP id k8mr6673618edl.119.1632414153289; Thu, 23 Sep 2021 09:22:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h8sm3374154ejj.22.2021.09.23.09.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 09:22:32 -0700 (PDT) Subject: Re: [PATCH 0/3] KVM: x86: guest.MAXPHYADDR fix and related cleanup To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+200c08e88ae818f849ce@syzkaller.appspotmail.com References: <20210831164224.1119728-1-seanjc@google.com> From: Paolo Bonzini Message-ID: <5f9dccf3-0b11-a10d-11a2-e8ebe7e4b6dc@redhat.com> Date: Thu, 23 Sep 2021 18:22:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831164224.1119728-1-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/21 18:42, Sean Christopherson wrote: > Fix a bug exposed by syzkaller where running with guest.MAXPHYADDR < 32 > leads KVM injecting a garbage exception due to mishandling an illegal GPA > check when "translating" a non-nested GPA. > > Clean up tangentially related code in load_pdptrs() to discourage reading > guest memory using a potentially-nested GPA. > > Sean Christopherson (3): > Revert "KVM: x86: mmu: Add guest physical address check in > translate_gpa()" > KVM: x86: Subsume nested GPA read helper into load_pdptrs() > KVM: x86: Simplify retrieving the page offset when loading PDTPRs > > arch/x86/include/asm/kvm_host.h | 3 -- > arch/x86/kvm/mmu/mmu.c | 6 ---- > arch/x86/kvm/x86.c | 56 +++++++++++---------------------- > 3 files changed, 18 insertions(+), 47 deletions(-) > Queued 2 and 3 too now, thanks. Paolo