From: Ryan Roberts <ryan.roberts@arm.com>
To: Fuad Tabba <fuad.tabba@linux.dev>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Yang Shi <yang@os.amperecomputing.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Fuad Tabba <tabba@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: pi: Add an ISB after mapping the FDT in the initial ID map
Date: Sat, 21 Nov 2026 10:42:11 +0000 [thread overview]
Message-ID: <5f9eae39-b82c-4fb3-9bea-c49a6b7baf25@arm.com> (raw)
In-Reply-To: <20261120121638.194154-2-fuad.tabba@linux.dev>
On 20/11/2026 12:16, Fuad Tabba wrote:
> map_fdt() maps the FDT into the live initial ID map with only a DSB
> before the caller reads it, so the read can fault on a translation made
> speculatively before the mapping was written. This early in boot,
> VBAR_EL1 doesn't yet point at the kernel's vectors, and the kernel fails
> to boot.
>
> Add an ISB after the DSB.
>
> Fixes: 84b04d3e6bdbc ("arm64: kernel: Create initial ID map from C code")
> Cc: stable@vger.kernel.org
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
I did a quick audit of all the other DSBs without ISBs in the pi code and I
think the rest are all correct because they are not synchronising stores to
_live_ tables so there can't have been any speculation with the old invalid value.
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
> arch/arm64/kernel/pi/map_kernel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/pi/map_kernel.c b/arch/arm64/kernel/pi/map_kernel.c
> index fb44cbdd2f292..f9338257adb7d 100644
> --- a/arch/arm64/kernel/pi/map_kernel.c
> +++ b/arch/arm64/kernel/pi/map_kernel.c
> @@ -211,6 +211,7 @@ static void *__init map_fdt(phys_addr_t fdt)
> fdt, PAGE_KERNEL, IDMAP_ROOT_LEVEL,
> (pte_t *)init_idmap_pg_dir, false, 0);
> dsb(ishst);
> + isb();
>
> return (void *)fdt;
> }
next prev parent reply other threads:[~2026-11-21 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:16 [PATCH 0/3] arm64: Missing barriers in kernel page-table updates Fuad Tabba
2026-11-20 12:16 ` [PATCH 1/3] arm64: pi: Add an ISB after mapping the FDT in the initial ID map Fuad Tabba
2026-11-21 10:42 ` Ryan Roberts [this message]
2026-11-20 12:16 ` [PATCH 2/3] arm64: mm: Add an ISB after remapping the KPTI page-table slot Fuad Tabba
2026-11-21 10:48 ` Ryan Roberts
2026-11-20 12:16 ` [PATCH 3/3] arm64: mm: Don't defer the barriers when installing a fixmap entry Fuad Tabba
2026-11-21 11:01 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9eae39-b82c-4fb3-9bea-c49a6b7baf25@arm.com \
--to=ryan.roberts@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®