From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>
Cc: <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <lanhao@huawei.com>,
<shenjian15@huawei.com>
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: remove unused parameter of am65_cpsw_nuss_common_open()
Date: Sat, 17 Sep 2022 10:03:56 +0800 [thread overview]
Message-ID: <5fa1abb7-a6df-b78c-0faf-af06d56e9e75@huawei.com> (raw)
In-Reply-To: <20220916023541.23415-1-huangguangbin2@huawei.com>
Sorry, please ignore this patch because target tree name is
not specified in the subject and not cc s-vadapalli@ti.com.
I will send this patch again.
On 2022/9/16 10:35, Guangbin Huang wrote:
> From: Jian Shen <shenjian15@huawei.com>
>
> The inptu parameter 'features' is unused now. so remove it.
>
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 7ef5d8208a4e..4f8f3dda7764 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -363,8 +363,7 @@ static void am65_cpsw_init_host_port_emac(struct am65_cpsw_common *common);
> static void am65_cpsw_init_port_switch_ale(struct am65_cpsw_port *port);
> static void am65_cpsw_init_port_emac_ale(struct am65_cpsw_port *port);
>
> -static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common,
> - netdev_features_t features)
> +static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
> {
> struct am65_cpsw_host *host_p = am65_common_get_host(common);
> int port_idx, i, ret;
> @@ -577,7 +576,7 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev)
> for (i = 0; i < common->tx_ch_num; i++)
> netdev_tx_reset_queue(netdev_get_tx_queue(ndev, i));
>
> - ret = am65_cpsw_nuss_common_open(common, ndev->features);
> + ret = am65_cpsw_nuss_common_open(common);
> if (ret)
> return ret;
>
>
prev parent reply other threads:[~2022-09-17 2:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 2:35 Guangbin Huang
2022-09-17 2:03 ` huangguangbin (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa1abb7-a6df-b78c-0faf-af06d56e9e75@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®