From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751513AbdAaL2q (ORCPT ); Tue, 31 Jan 2017 06:28:46 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36387 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750750AbdAaL2k (ORCPT ); Tue, 31 Jan 2017 06:28:40 -0500 Subject: Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero() To: Fabian Frederick , Andrew Morton References: <20170130184723.18186-1-fabf@skynet.be> Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org From: Ursula Braun Date: Tue, 31 Jan 2017 12:28:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170130184723.18186-1-fabf@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17013111-0028-0000-0000-000002A11CBF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17013111-0029-0000-0000-00002236EF98 Message-Id: <5faaa712-63d3-7462-ad58-39a22ead8e0a@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701310100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACK - compile-tested successfully on s390. On 01/30/2017 07:47 PM, Fabian Frederick wrote: > instead of atomic_add_unless(value, -1, 0) > > Signed-off-by: Fabian Frederick > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 315d8a2..9595b90 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -3278,7 +3278,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index) > atomic_set(&card->force_alloc_skb, 3); > count = newcount; > } else { > - atomic_add_unless(&card->force_alloc_skb, -1, 0); > + atomic_dec_not_zero(&card->force_alloc_skb); > } > > if (!count) { >