From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C48C56201 for ; Wed, 11 Nov 2020 09:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07507206CA for ; Wed, 11 Nov 2020 09:34:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pox7M5sP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbgKKJeV (ORCPT ); Wed, 11 Nov 2020 04:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbgKKJeU (ORCPT ); Wed, 11 Nov 2020 04:34:20 -0500 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD758C0613D1; Wed, 11 Nov 2020 01:34:19 -0800 (PST) Received: by mail-oi1-x242.google.com with SMTP id k26so1527366oiw.0; Wed, 11 Nov 2020 01:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=36NotezYoC/yyfzMqnUfq9zBlq7QxW9QNIrKCRtwRLY=; b=pox7M5sP0Uml+SVYXZ08brVDykvoVVYnZgc8mI0lk93NjnXTmtpK1ZYotFvDa5qcux dlxxF/miW84iYycj9tSsv9N2V18A+StM1WI7N+xcCi3WDkkFKPZSI+733Uv+bMyzexGn c3uhgUZIJhDMtX3sIxNyjApC0U5zJzjEX1lh1jCeW0cWRGi51pdLmHRBGyoErj29fakz SBOohq3UMWrlzkNllxkf4zixaqOAwu8svdoowwW6QzlPOxjtfFgkWjNQhyoIi3zbwHYD oBBD4ZkLGHy509OP4bqbI4kD+MomUXeI1zsA83Rw58cFkK84vInW0gdmsjDDpWcFy78X 7S7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=36NotezYoC/yyfzMqnUfq9zBlq7QxW9QNIrKCRtwRLY=; b=qOkngKCC2WMXthS+9m2gisXo4uaV8+DY5Ps8yxKD6pWWeGINxbevR7JtOTozARk+mt PHVoGUIGBigNAXfvoX5iTIH3QsFfYRaCcuvkZsrss3njY42cNss1IIlCuExzpH5Wksuq T1z3LgM8726gDKvLSwO25qbeRwJK4kbEvPKz7gdCFCadpXACRTjIylvTFT/+WWh7mzTM RjyElHfVBAh2OCYF0fnKV5D19IdeiFLAiO6rBc4zh6nAxs9AxZ4IP30QuvwX4gtxZ+r8 aIoYgf4vC1P4cP94q77CNFhM4EvejUUqEPWIfoKFVKvghcjkLiG/1ypSQeL12Yd6crTg rZGw== X-Gm-Message-State: AOAM531Zi2mf0tHmuMfETw0WHn9ekPosHmZ/NpXQJ5iWBlN6cX7FiWru wTU/Drg3pW1bfgqadXiY0H8= X-Google-Smtp-Source: ABdhPJxhY6BIamR+E6BAfcKKF3uledUuIVKFBCbjublGaqm/oVke/eYtwlyVeUJgab9VzMzvQto6kA== X-Received: by 2002:aca:4a0d:: with SMTP id x13mr1603348oia.155.1605087259295; Wed, 11 Nov 2020 01:34:19 -0800 (PST) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id q18sm392421otf.46.2020.11.11.01.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 01:34:18 -0800 (PST) Date: Wed, 11 Nov 2020 01:34:11 -0800 From: John Fastabend To: Andrii Nakryiko , xiakaixu1987@gmail.com Cc: Alexei Starovoitov , Daniel Borkmann , Martin Lau , Song Liu , Yonghong Song , Andrii Nakryiko , john fastabend , KP Singh , Networking , bpf , open list , Kaixu Xia Message-ID: <5fabb0135718_bb260208a8@john-XPS-13-9370.notmuch> In-Reply-To: References: <1605071026-25906-1-git-send-email-kaixuxia@tencent.com> Subject: Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:03 PM wrote: > > > > From: Kaixu Xia > > > > The unsigned variable datasec_id is assigned a return value from the call > > to check_pseudo_btf_id(), which may return negative error code. > > > > Fixes coccicheck warning: > > > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0 > > > > Reported-by: Tosk Robot > > Signed-off-by: Kaixu Xia > > --- > > Looks good. > > Acked-by: Andrii Nakryiko > > [...] Acked-by: John Fastabend