From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD46239E7D for ; Mon, 17 Nov 2025 19:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763406562; cv=none; b=Gk3LHYsMCA4foEAdZZ4F1nV279RSPYjD/1WrTPpqPkkmbjHhxGiNJ/D3jXJdMVcpaO9JA7dWRIKdEQ8LCtA2HGdhb7cSqceVSmdo4l2Ai21C6NBDvjgW3kOjvIg4dALDIQw1ky4buo2/tDES5MwSKcuAm3vnBeNrBcPXTyIsYZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763406562; c=relaxed/simple; bh=N6lvokc+GVi2kQfbHJWWQQFpb9Vfpaor53D51REOhtk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EUi7I2n2ZqUyHrUklc/VaW75afZ4LsE5XhQt4QWENZVYSMIi7mq/pYH992Mzws9xeVS5xSxhKfm7XgeYk6VaDEl7XK+ry6t/pyVC5gmLxXvYOAbt7sXComjOjwbJ9OHirFxLM6qRDs46dl7N2Xn354hbOvkhXJ63gFUZ7EIeGBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Y9cQNk9F; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Y9cQNk9F" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=KNPcuHKHfiBqBjqMSbP9BIFYWBXjXjiNeX+JayWpnhM=; b=Y9cQNk9FjBxArGNTmwZmkxnOQK EoBezDSxihcNllm0ND6SpWlnuEFm0TCfJVNSvhgORCbzlO6o22k5r8Nl2InhzsdzRrnG+Wi1uB2h+ F1tLjikxlpxabpltu59FpnssKOgOAWFjtmkLQh/RtpW2w+OolmLlHE7xBs8fyo6EX+Altkjvg8XIZ RHud2wlTy3GmU6hjUINowpX1zFzsYaD4DFRcQs6gwU7qsAFCm9IunSZ9q1ITseSeq5hiIB003Dxth o1vuno+RSfT7SIWQSpIMySXcXMygSl/2HOD5hU64xDe7iIv6R2ji/LFBuW5xAPRGPk+jNKO316Zdv L+Ypai3g==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vL4bH-0000000Ghdj-3LQO; Mon, 17 Nov 2025 19:09:19 +0000 Message-ID: <5fadee48-4a35-40ef-aac2-eb307e2ee869@infradead.org> Date: Mon, 17 Nov 2025 11:09:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mtd: docg3: fix kernel-doc warnings To: Miquel Raynal Cc: linux-kernel@vger.kernel.org, Robert Jarzmik , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org References: <20251116070944.84071-1-rdunlap@infradead.org> <874iqtf576.fsf@bootlin.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <874iqtf576.fsf@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/17/25 12:12 AM, Miquel Raynal wrote: > Hi Randy, > > On 15/11/2025 at 23:09:44 -08, Randy Dunlap wrote: > >> Fix kernel-doc warnings in docg3.h to avoid build warnings and to >> improve and documentation: > > "to improve and documentation" is incorrect, can you please fix? ugh. Yes, will fix. >> Warning: ../drivers/mtd/devices/docg3.h:276 bad line: >> Warning: drivers/mtd/devices/docg3.h:299 struct member 'max_block' not >> described in 'docg3' >> >> Signed-off-by: Randy Dunlap >> --- >> Cc: Robert Jarzmik >> Cc: Miquel Raynal >> Cc: Richard Weinberger >> Cc: Vignesh Raghavendra >> Cc: linux-mtd@lists.infradead.org >> --- >> drivers/mtd/devices/docg3.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> --- linux-next-20251114.orig/drivers/mtd/devices/docg3.h >> +++ linux-next-20251114/drivers/mtd/devices/docg3.h >> @@ -274,11 +274,12 @@ struct docg3_cascade { >> * @cascade: the cascade this device belongs to >> * @device_id: number of the cascaded DoCG3 device (0, 1, 2 or 3) >> * @if_cfg: if true, reads are on 16bits, else reads are on 8bits >> - >> + * > > Wrong fix I believe. What make you think a space is relevant here? The '*' is relevant here. A blank line of kernel-doc should have a beginning asterisk: * >> * @reliable: if 0, docg3 in normal mode, if 1 docg3 in fast mode, if 2 in >> * reliable mode >> * Fast mode implies more errors than normal mode. >> * Reliable mode implies that page 2*n and 2*n+1 are clones. >> + * @max_block: maximum block number for this device >> * @bbt: bad block table cache >> * @oob_write_ofs: offset of the MTD where this OOB should belong (ie. in next >> * page_write) > > Thanks, > Miquèl -- ~Randy