From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Erikas Bitovtas <xerikasxx@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Hansson <newbyte@postmarketos.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, David Heidelberg <david@ixit.cz>,
Abel Vesa <abelvesa@kernel.org>
Subject: Re: [PATCH v4] arm64: dts: qcom: sm7125-samsung: add initial device tree
Date: Fri, 16 Oct 2026 12:56:35 +0200 [thread overview]
Message-ID: <5fb086d1-7725-4d8b-a2c9-7627f6da7cd9@oss.qualcomm.com> (raw)
In-Reply-To: <20261013-sm7125-samsung-v4-1-3233901b48bb@gmail.com>
On 10/13/26 3:58 PM, Erikas Bitovtas wrote:
> Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform
> in 2021. Add initial device tree for SM7125 Samsung platform with
[...]
> +&soc {
> + i2c_17: i2c-17 {
This is not a MMIO device, so it doesn't belong under /soc
Have you tried using the bus through the normal QUP driver path?
> + compatible = "i2c-gpio";
> + sda-gpios = <&tlmm 51 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&tlmm 52 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
style nit: (foo | bar) instead of (foor|bar), please
[...]
> +&usb_1 {
> + qcom,select-utmi-as-pipe-clk;
Is there no superspeed / DP altmode?
Konrad
next prev parent reply other threads:[~2026-10-16 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 13:58 Erikas Bitovtas
2026-10-16 10:56 ` Konrad Dybcio [this message]
2026-10-17 13:29 ` Erikas Bitovtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb086d1-7725-4d8b-a2c9-7627f6da7cd9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=newbyte@postmarketos.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®