From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9172CCE79A8 for ; Tue, 19 Sep 2023 17:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231989AbjISRPi (ORCPT ); Tue, 19 Sep 2023 13:15:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231955AbjISRPf (ORCPT ); Tue, 19 Sep 2023 13:15:35 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 616F0DC; Tue, 19 Sep 2023 10:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1695143727; bh=ZECM0iIszLRK6JxiliXqM6gNdR0WNCsq3C/p8MYEDtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NA4gmUrCEKYQddDUZXd/IG9YM0AXgGNaSlKLK8/w1YkDZQXw7fwfCaizBBStqeue9 +pKLBUwYqivwKCj9Hya/nMDUr3pbnQHKyLF2jZN7aqP9DTEYIMUrOzllYY3ZF/IyBa gSJ7L2VFysnmXQsdb9w1p+xHK69oaOsWhwFO+I+Q= Date: Tue, 19 Sep 2023 19:15:25 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Guenter Roeck Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Gilbert Subject: Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C Message-ID: <5fb278c7-df91-4f02-ab5f-baa47d27507f@t-8ch.de> References: <20230911-powerz-km002c-v1-1-898bd79b9bae@weissschuh.net> <6e5eff10-949c-4f17-a3f3-347b85b89e11@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6e5eff10-949c-4f17-a3f3-347b85b89e11@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-09-18 12:05:19-0700, Guenter Roeck wrote: > On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote: > > The KM002C is similar to the KM003C and seems to use the same > > protocol and firmware. > > > > Reported-by: Douglas Gilbert > > Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/ > > Signed-off-by: Thomas Weißschuh > > --- > > > > This patch is based on hwmon-next, > > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers"). > > > > Signed-off-by: Thomas Weißschuh > > Applied, but please be more careful with your comments and Signed-off-by: > tags. There should only be one '---', and one signature. Thanks, the duplicate Signed-off-by is indeed an oversight which I'll try to avoid in the future. As for the '---': Two of them are generated by the 'b4' tool and I added one manually with the hwmon-next information. For other subsystems this wasn't an issue so far. Are these duplicate sections a problem for your personal tooling or is it affecting something more widespread? I can try to avoid these issues when sending patches to you specifically or maybe changes in b4 in general are the correct solution. Thomas > > --- > > drivers/hwmon/powerz.c | 1 + > > 1 file changed, 1 insertion(+) > > > > > > --- > > base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4 > > change-id: 20230911-powerz-km002c-94afb4d3d645 > > > > Best regards, > > > > diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c > > index 2b9693aee6f6..cfb635f94d66 100644 > > --- a/drivers/hwmon/powerz.c > > +++ b/drivers/hwmon/powerz.c > > @@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf) > > } > > > > static const struct usb_device_id powerz_id_table[] = { > > + { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */ > > { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */ > > { } > > };