From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659CAC433FE for ; Wed, 23 Mar 2022 06:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242028AbiCWG5X (ORCPT ); Wed, 23 Mar 2022 02:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232801AbiCWG5T (ORCPT ); Wed, 23 Mar 2022 02:57:19 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105D371ED7; Tue, 22 Mar 2022 23:55:50 -0700 (PDT) Received: from [192.168.0.3] (ip5f5ae903.dynamic.kabel-deutschland.de [95.90.233.3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 7991161EA1928; Wed, 23 Mar 2022 07:55:48 +0100 (CET) Message-ID: <5fb6af7b-d84f-cbae-7eb1-543f3a7e53e4@molgen.mpg.de> Date: Wed, 23 Mar 2022 07:55:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 3/3] ata: ahci: Skip 200 ms debounce delay for AMD 300 Series Chipset SATA Controller Content-Language: en-US To: Damien Le Moal , Mario Limonciello Cc: Hans de Goede , linux-ide@vger.kernel.org, LKML , Nehal-bakulchandra Shah References: <20220321212431.13717-1-pmenzel@molgen.mpg.de> <20220321212431.13717-3-pmenzel@molgen.mpg.de> From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Damien, Am 23.03.22 um 06:01 schrieb Damien Le Moal: > On 3/22/22 06:51, Limonciello, Mario wrote: >> [Public] >> >>> -----Original Message----- >>> From: Paul Menzel >>> Sent: Monday, March 21, 2022 16:25 […] >> I seem to recall that we were talking about trying to drop the debounce delay for >> everything, weren't we? >> >> So perhaps it would be right to add a 4th patch in the series to do just that. Then >> If this turns out to be problematic for anything other than the controllers in the >> series that you identified as not problematic then that 4th patch can potentially >> be reverted alone? > > Not quite everything :) But you are right, let's try to switch the default > to no delay. I will be posting patches today for that. > > Paul, > > With these patches, your patches are not necessary anymore as the AMD > chipset falls under the default no-delay. I am all for improving the situation for all devices, but I am unable to judge the regression potential of changing this, as it affects a lot of devices. I guess it’d would go through the next tree, and hopefully the company QA teams can give it a good spin. I hoped that my patches, as I have tested them, and AMD will hopefully too, could go into the current merge window. > It would be nice if you can test though. Of course, I am going to that either way. Kind regards, Paul