mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Ian Rogers <irogers@google.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	Elkin Cruz <elkin@google.com>
Subject: Re: [PATCH 1/2] drm/amdgpu: initialize r in amdgpu_vm_bo_update()
Date: Fri, 20 Nov 2026 13:07:59 +0100	[thread overview]
Message-ID: <5fb8ce65-923e-4714-946d-ecaa4ecad399@amd.com> (raw)
In-Reply-To: <e8d983aa6f81be52ea1bb9afc9c0f47d4632c1db.1795106955.git.irogers@google.com>



On 11/19/26 18:07, Ian Rogers wrote:
> Commit bc566781845b ("drm/amdgpu: stop syncing PRT map operations") added
> an 'else if (!bo)' branch in amdgpu_vm_bo_update() that does not assign
> 'r'. Because fpriv->prt_va has bo == NULL and is updated on every command
> submission, userqueue validation, and KFD VM restore, calling
> amdgpu_vm_bo_update(adev, fpriv->prt_va, false) when bo_va->invalids is
> empty skips the mapping loop and returns uninitialized stack variable 'r'.
> 
> Initialize 'r' to 0.
> 
> Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
> -Wconditional-uninitialized enabled; fix and changelog drafted with an AI
> coding assistant. Build-tested under LLVM=1 W=1 (-Werror) and
> -Wconditional-uninitialized; not runtime-tested on AMD GPU hardware.
> 
> Fixes: bc566781845b ("drm/amdgpu: stop syncing PRT map operations")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 82b9b2d5d0cf..091589b2c524 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1303,7 +1303,7 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, struct amdgpu_bo_va *bo_va,
>  	uint64_t vram_base;
>  	uint64_t flags;
>  	bool uncached;
> -	int r;
> +	int r = 0;

Good catch, but please don't initialize return variables a default value.

That is often seen as bad coding style and often hides problems instead of fixing them.

Instead just initialize r in the if branch where it is missing.

Thanks,
Christian.

>  
>  	amdgpu_sync_create(&sync);
>  	if (clear) {


  reply	other threads:[~2026-11-20 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:07 [PATCH 0/2] drm/amdgpu: Initialize r in VM and TTM buffer helpers Ian Rogers
2026-11-19 17:07 ` [PATCH 1/2] drm/amdgpu: initialize r in amdgpu_vm_bo_update() Ian Rogers
2026-11-20 12:07   ` Christian König [this message]
2026-11-19 17:07 ` [PATCH 2/2] drm/amdgpu: initialize r in amdgpu_ttm_clear_buffer() Ian Rogers
2026-11-20 12:11   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fb8ce65-923e-4714-946d-ecaa4ecad399@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=elkin@google.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®