From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF59130BF4F for ; Mon, 3 Aug 2026 08:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785746142; cv=none; b=B+bi71tUVRlJP0EdM9ER82A8EWttpStkS3vX938K4Ey0gcDcBrjMkD920ogvbm88ZkMYqATtf88zAFM2sqx6ijk+zdcRSsYj91s+EjxneRuQtDQLp1IUUYAViDo64A/c2VJaM4rZZjY1GMdxWOmM8Y9NnlID8H9Fuhx5TftrEEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785746142; c=relaxed/simple; bh=8ap7yGjWYByUjArdraJwOeD0GBIWQOypd1BJAD9XB/M=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=XC/tVxEO5Sg1SJk3hWqs2NvzfQb+6osmbNF+jNeFSem2zzgTqJYpA5dUcZyYPNulMxaFaFyk/N5bbhUWuF2CpMOpBknt42PlEwfLKTdw9CFTY+zz9F+EEokQmTDhfTf/uHbm597EipO92JfCeZDN7Ym4NWTTXL8zTKnVQwLVPhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AHKNA6gh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AHKNA6gh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB0F1F00A3A; Mon, 3 Aug 2026 08:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785746141; bh=msb+HXJfxnhAfoW4KbBd6lps3PsbR5Bw0tJ4Un9C/ak=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=AHKNA6ghfsS+ywvuXTU+Pc381TNlqncT1WmTrdWW+kjeINB88zOpTfFJ5IAICG5ux mQKVraYelQeW4PZUMawajiJ76fz4rlCJ7f9owlqMqZnQ6bxMJG9HAtEGjCkY7gTKMl W6oj7JiC8sSrz5NvKgWRiLz9sJyQxqZjUCavPBxvB0BP+E21H4AhEZDz9Js7t/o1s6 5BnfkLPutWbRqGRqEA1/COPSFHP++fb+FwysElAsZu8z6r4R4/VQXK2hxBt+guMflU vGkNBasXDbqwjvnpnHjvb+jmJqQi7UrPic3TPJUqAl8AQo5LbEh42VCr2OJgU0sIlu 2pPzbw4PCOeqQ== Message-ID: <5fba64e0-dbaa-455f-b11f-f63ccd675887@kernel.org> Date: Mon, 3 Aug 2026 16:35:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, stable@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH] f2fs: return writeback error from collapse range To: Wenjie Qi , jaegeuk@kernel.org References: <20260727074910.1965988-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260727074910.1965988-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/27/26 15:49, Wenjie Qi wrote: > f2fs_collapse_range() writes back pages moved by f2fs_do_collapse(), > but ignores the return value. If writeback fails, the ioctl can still > truncate page cache, shrink blocks, and report success. > > Return the error before truncating page cache or updating the file size. > > Fixes: b4ace3370324 ("f2fs: support FALLOC_FL_COLLAPSE_RANGE") > Cc: stable@kernel.org > Assisted-by: Codex:gpt-5.5 > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu Thanks,