From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754169AbdDOR3q (ORCPT <rfc822;w@1wt.eu>);
        Sat, 15 Apr 2017 13:29:46 -0400
Received: from mout.web.de ([212.227.15.14]:60627 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751364AbdDOR3o (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 15 Apr 2017 13:29:44 -0400
Subject: Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Sangbeom Kim <sbkim73@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <b0fc50c2-4552-93d1-1ae0-42f78d255fe9@users.sourceforge.net>
 <542252e0-817f-ce13-fbd5-8fd8dda4c746@users.sourceforge.net>
 <20170415104845.bofxl34wr7z7khix@kozik-lap>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <5fbe1743-2d68-4959-d71d-ed9dfca69eb5@users.sourceforge.net>
Date: Sat, 15 Apr 2017 19:29:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <20170415104845.bofxl34wr7z7khix@kozik-lap>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:XaO8FXg5U4I/gP8bfdsDtEOjr+25N17URV551eZMZUzOJu+Sx25
 taXccgZFubt6ogH+LwxgL7BKCRHSbEjZydAQoc1jaoLQ6tMI7oICmiDOsp3eSlm7K6UQ8Cb
 UWZxtPKLO+Rl1mT33n06EVE9NAbuqPLM5IczjaLmSSEqfGAEpvsuuhwMrgRCJXkTSrkjeOQ
 9t2TlOGSuFuM78aH5GgHg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:XAteFIzcGwI=:xqqfrJOOEsCA2FZJNvowpc
 I/m6SUxMqzlIJnG3lVe+AbxA1Hrj5PqnYDrHIoU2PWrADtEgV1zWV7f1x8v6tCzWnjFaiSOhA
 6ZsqMtiVLb7UAKuaG+LUXWhtzKdsAbtAy2jhmIsXVld+bWsoXDbw44aC4j2brayvGugKw9Xj6
 tc2FhAgqrqFqRKAY+WyZXh3MscMovixbX8bhUYP/rD6kxDoX65J4/UhgbTvBT3GZ0a2YjPn4S
 Bvtj/pIx7pJVF9WyG5UpanjqYD07QLLWOjeQ13W4cbVqNO+m2EfWlNohdTI5Xuapr7P+uOGLC
 gVbfaMCwVTZ7EgHR1tdcv7jRVaP9s16dDBwYAirpPhb5DuEWHrq0Sy0IvrIXMnOmrigxP2E52
 jnsddF1cG2i6ReB4orQ7CJarJw8WG6hrzkLJsW5BPMtoogTyLc5RGHNypjNkHt+qIp+wrP6gk
 RiOY+fnOaCDTactBz2HiaEVSvVQ30P+FAluwPB/aVHHaLemMoXQwVj/7yyMKoumy+HNHHp78P
 x3TkR5x6OMSB7VBmwLjzkfM4zCxCcscBTjQIW/A8sdXzdcj+s8IUb54fWffk2HspHmon0EAiG
 rE5z2nBNCl4Ct5eiLsad3p1R5lQmuJ4X/RSLl09NHBLZj7j5jyiP00ZW0pKzb4DkT4tbLQ0mw
 TVqby0gJuZuvB7jovyWVqXIu230nq/GjDViAXH7ld0pAPsxxZ2ORmLjVpFnZyY0blWyoRLoKe
 T6dVyrxAaS/GUbHHxXZOR+y1RioEBL5wYNNtghZDvtYDShwBJMX5oB5q/4t5g6WOkn0PywmzM
 NwCTNQ7
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kcalloc".
>>
>> This issue was detected by using the Coccinelle software.
> 
> Unfortunately you write mostly cryptic commit messages.

Thanks for your feedback.


> This does not answer for the main question - why this change is needed.

My update suggestion affects an aspect for the coding style.


> Code looks okay,

There can be different opinions about related implementation details.


> but you should explain in simple words why this is needed.

Do you find the following wording from the script “checkpatch.pl”
better to understand?

WARNING: Prefer kcalloc over kzalloc with multiply


Regards,
Markus