From: Guenter Roeck <linux@roeck-us.net>
To: Kees Cook <keescook@chromium.org>
Cc: Marco Elver <elver@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>, Tom Rix <trix@redhat.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] ubsan: Tighten UBSAN_BOUNDS on GCC
Date: Wed, 21 Jun 2023 17:50:53 -0700 [thread overview]
Message-ID: <5fbe4977-c56d-2d97-bea3-28148807b5d9@roeck-us.net> (raw)
In-Reply-To: <202306211051.1D4038323@keescook>
On 6/21/23 10:52, Kees Cook wrote:
> On Wed, Jun 21, 2023 at 09:42:01AM -0700, Guenter Roeck wrote:
>> Hi,
>>
>> On Tue, Apr 04, 2023 at 07:23:59PM -0700, Kees Cook wrote:
>>> The use of -fsanitize=bounds on GCC will ignore some trailing arrays,
>>> leaving a gap in coverage. Switch to using -fsanitize=bounds-strict to
>>> match Clang's stricter behavior.
>>>
>>> Cc: Marco Elver <elver@google.com>
>>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>>> Cc: Nathan Chancellor <nathan@kernel.org>
>>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>>> Cc: Nicolas Schier <nicolas@fjasle.eu>
>>> Cc: Tom Rix <trix@redhat.com>
>>> Cc: Josh Poimboeuf <jpoimboe@kernel.org>
>>> Cc: Miroslav Benes <mbenes@suse.cz>
>>> Cc: linux-kbuild@vger.kernel.org
>>> Cc: llvm@lists.linux.dev
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>> ---
>>
>> This patch, presumably as side effect, enables CONFIG_ARCH_STM32
>> for arm64:allmodconfig. As consequence, CONFIG_STM32_RPROC is enabled
>> as well. This in turn results in the following build error.
>>
>> Building arm64:allmodconfig ... failed
>> --------------
>> Error log:
>> In file included from include/linux/printk.h:564,
>> from include/asm-generic/bug.h:22,
>> from arch/arm64/include/asm/bug.h:26,
>> from include/linux/bug.h:5,
>> from include/linux/fortify-string.h:5,
>> from include/linux/string.h:254,
>> from include/linux/dma-mapping.h:7,
>> from drivers/remoteproc/stm32_rproc.c:9:
>> drivers/remoteproc/stm32_rproc.c: In function 'stm32_rproc_mem_alloc':
>> drivers/remoteproc/stm32_rproc.c:122:22: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'size_t'
>>
>> I did not try to understand what is going on, but reverting this
>> patch fixes the problem.
>
> Well that is really weird! I will investigate... this patch should be
> pretty self-contained...
>
Meh, it is. Sorry for the noise. My bisect script was wrong.
Guenter
next prev parent reply other threads:[~2023-06-22 0:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 2:23 Kees Cook
2023-04-07 22:00 ` Nick Desaulniers
2023-06-21 16:42 ` Guenter Roeck
2023-06-21 17:52 ` Kees Cook
2023-06-22 0:50 ` Guenter Roeck [this message]
2023-06-22 3:11 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fbe4977-c56d-2d97-bea3-28148807b5d9@roeck-us.net \
--to=linux@roeck-us.net \
--cc=elver@google.com \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lukas.bulwahn@gmail.com \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=sudipm.mukherjee@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®