Re: [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: add ath10k calibration variant

[David Heidelberg <david@ixit.cz>]

On 10/11/2025 16:58, Dmitry Baryshkov wrote:
> On Mon, Nov 10, 2025 at 04:37:46PM +0100, David Heidelberg via B4 Relay wrote:
>> From: Dylan Van Assche <me@dylanvanassche.be>
>>
>> SDM845-based Oneplus 6 and 6T have their own calibration files
>> for the WCN3990 WiFi/Bluetooth radio with the ath10k driver.
>> Add the calibration variant name to the DTS to reflect this to
>> allow using the calibration files from linux-firmware.
>>
>> [David] Adjust the compatible as ath10k-calibration-variant is deprecated
>> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index db6dd04c51bb5..a0c2f6efec59d 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -929,5 +929,6 @@ &wifi {
>>   	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>>   	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>>   
>> +	qcom,calibration-variant = "oneplus_sdm845";
> 
> oneplus_sdm845_6? or oneplus_6_6t? SDM845 is too broad.

I verified with 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ath10k/WCN3990/hw1.0/board-2.bin

$ strings board-2.bin | rg oneplus
bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=oneplus_sdm845mmm

$ ./ath10k-bdencoder -e ~/Downloads/board-2.bin
...
bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=oneplus_sdm845.bin 
created size: 19152
...

Since OP6/6T should have same WiFi.

David>
> BTW: Were those board files sent to the ath10k ML for inclusion?
> 
>>   	qcom,snoc-host-cap-8bit-quirk;
>>   };
>>
>> -- 
>> 2.51.0
>>
>>
> 
-- 
David Heidelberg