From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15B9B3AEB37 for ; Wed, 13 May 2026 19:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778700436; cv=none; b=Cf2T19XbhQXDgJ6VXkdVv4HQ4zwi6CwDd0flnOdgnDXnMOfQsHRb655U6GCLhcA8GxIP5ynqjSD9gDnVL2nMQkO94nVV5YYmWvegDJI6Oq2Hp4e4IlvIW3aSt9rTOaGkx2BaAhbM4jd+TiHUZCxcquDQsJvHufhkJjaSK27B0us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778700436; c=relaxed/simple; bh=tV3pv7xKKDP1+S0W7Yp+8gNmAXnCpGwI5fcu2TVBbGI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NivT4fmw6HGc2P7tgiiiL4fndoaRTFZXO+29SUlzdRLknSpTtYbcfy6c5l5vIIsQm2EX4xGz77vcIgpoARou/ThJpqKMtz3KvSbI3ZFWSxqiY1wn9E/vX5Vh7MBOYj9DBvptaukEI5DMu9mr69uc2sG449x737Qx9w1oeeE1HP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lgdRRt6s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VKqCmsQZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lgdRRt6s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VKqCmsQZ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DFduob1243001 for ; Wed, 13 May 2026 19:27:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XC1PMvPouH5s16VJkuyjTVmFB3EWh4Dc0i1OjLJSlro=; b=lgdRRt6sFBFm3XaY ys/pt33Wa5hjJqn7+akykyNrZozHF1viVZ26oPlIAcSrmALiqVta6EEs7qQfPzRr RHWwYDmE1HEtCkbJVsHiCJz5RN/Etf42i8G61UVkoOw1snUJk12ZfA5vvDkbSPqW GIHA44UgJ8BNtoa1Wpec7YmWvsTHkN0RKyTHkTdjGC/joYfMbT9isGiA74mmX6Qz w+OFopm6bYvmOoim17XhLtD+Eyp3pOOVDoJFy15/lTTVGWCv/NV6S0weQS4eA2iT uBiTpBpvFFVYZ1VrPb7rT4N2rP2SQgFCs9VawAtjRESEeEQkwPKJry9cv+GHAkWJ Szw+cw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4v4trxqr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 19:27:14 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8397b14a689so4467480b3a.2 for ; Wed, 13 May 2026 12:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778700433; x=1779305233; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XC1PMvPouH5s16VJkuyjTVmFB3EWh4Dc0i1OjLJSlro=; b=VKqCmsQZ6XpkHyJ7l8cEKPyBlapebStaIiZq/jLH99Tp5BaW41xCzgaVdUbi5KSim8 9Dlv/OY+tHn5sWDJXKEvnfr99MAnZHkn35PrOHS2NHuNne6djJVIExl0F9Qb9DYeYAxL QxXuo92yj6FrFywMjMr7LOmgA7O8pYvkqtqo19omPpmUjLX9JMkrpqpsyrxOg1TQdYR3 qri4XpN4Ngln7PN+Bm7bO6T1Eh8ZtoDeN1SALPU6WnwCuKW83xJW8V5VDFH1UTYsaQTp pOxWOB2XALM6TAAmsjE8G29VRg0MvS4fnzNOEqsv6AFPFYcuIKGG7s8YYCeAblgHmVRI QFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778700433; x=1779305233; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XC1PMvPouH5s16VJkuyjTVmFB3EWh4Dc0i1OjLJSlro=; b=HnATw4rWOGwPnsR5JoNGCGvDe8sdeK2Z2zVVHTiSD49Osr4bsIbRDZyGMb2u/Q8glx k5+w2C59WckH7dDaffErOEBNu3Qcqm2z0zX7ieMm/Ygk+RT5irO9J99TXxPWyH3Twzm1 IndF7ZIWdA4xyCfGF3rsCkTP4mgQsDqJqAh5n+pEdAVvlAWGDJ1Kg5/yTHFBCwJlfWzQ fv/qkg8tE8HFEx5PPRrEt+YzTAI7DxVtxgFdWhI1YxkAFFyMrpBwxDk9NOXUQ/RfLM2p yd7X6eWmSp8ArQx80urOu33rniXupTmISTu1aNov5WKSYOJaaq2DNw8BWjlqRaGlyB1Y QB5A== X-Forwarded-Encrypted: i=1; AFNElJ8HIiS9AGnoRMYAYzZGTuzw599ODE+EIWP1vmEfknPW776BJeHHHTDPJdFrFT2O1lT1/Dou2mDZBlVw96Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzixou2/+6nmMZ8zPV2kRBAo+dOBdFwJEkSiL/iQJ0AbLGfQHLK 7OSM1OCIYoKE9QAbmZS16LY5jcDroaMPoHaM217qRkU2JrALAZEevsWEm4meaqrXGwu4gVR8cT+ hK/W1Ue9pqyeIKU1cOjVXBLFBLEKuz5tDBkPxeH1rGc/b3FT6jCSeMVBfXrDG/5WeBa0= X-Gm-Gg: Acq92OEdMxGH7IQ+qlR7450nBlL0995OMeKcbh2/3WC2x+E30+6voSg9jSGNWesZoll pXxgRy4aY8HHXIiBT/hv41aSfBhPw+mqGgmORsLQYEXzjrLa6uE3TQQWWJ1P/SG8RDXONVQBlPu HUYnK/ZPLtQIJ17AhHTqZt+JYHTfRNZfmK1cRWsZOMUk/yJe/O5qEsOHJZ3zrTjgQeQkHeqRtoA B8LXqrbtAGkHGFpXn+Pqc6bvfWvljQNyTc5y4h/cAe7oWISFMjsCjF5CIoy9BZ4lO+ggh59Ygj0 vtyKkL8BPsoGU7L3Dy1cIeH/NB90S1zvI+aptyNEAV3V3liY6dwN+wXwQ82zw4dWnq6PU5vjn1t 7Ymr93hjyAYebaLdXT2SpH19kQ1nME2bGegrW72PxSfR0t3Boq0oE5N32 X-Received: by 2002:a05:6a00:14c3:b0:838:af72:fb35 with SMTP id d2e1a72fcca58-83f03e949f1mr5153315b3a.10.1778700433461; Wed, 13 May 2026 12:27:13 -0700 (PDT) X-Received: by 2002:a05:6a00:14c3:b0:838:af72:fb35 with SMTP id d2e1a72fcca58-83f03e949f1mr5153290b3a.10.1778700432966; Wed, 13 May 2026 12:27:12 -0700 (PDT) Received: from [192.168.0.172] ([49.205.255.126]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19664220sm289587b3a.4.2026.05.13.12.27.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 12:27:12 -0700 (PDT) Message-ID: <5fc62574-fae1-4bf0-b6b9-fb6fb33041f8@oss.qualcomm.com> Date: Thu, 14 May 2026 00:57:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats To: Neil Armstrong , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <20260511-topic-sm8x50-iris-10bit-decoding-v3-5-7fc049b93042@linaro.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260511-topic-sm8x50-iris-10bit-decoding-v3-5-7fc049b93042@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XIIAjwhE c=1 sm=1 tr=0 ts=6a04d092 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=6GFGFuPpdQFN+sW0UwB+2Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=KKAkSRfTAAAA:8 a=vZN6g2wfPXE3sIqakpMA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE5MiBTYWx0ZWRfX8eJs+ZIN2cv3 fdtBqEMR8F1dqWiJfusN1KmsVJrTvFr3rpdltNQvRfFbYJCN1pH5b/i/cDqyHC8PIoiiQCypKjn baSt0h71EfG2vjlYJIw5IZL5XS2ZFKSksuBQp0gMWIicuDx2CyL9TDYwMD85n2L7EgdVGs5IAjA 5WXAbyzvlIaPID40zvbDcj/fxNR30aPCKMxXUCZX+z94/Xv6adA9vqODgHoRiE7JWbXFczom4Wq FqX3AfMxVVVRjeOd2iSACBu37/QLLXFXHIUxRLw0TevRMwPqw99o6xsDXi6E/t31Q5WA65dFIfQ OYr/2bnIurFnhj2NXu3ERJ7boPWPrbszDe/oYqF2lUZBCkBDzij+rEsRYkeSrphtZcHlTNvHulZ PqxJUUTEBzMsIuj8fFV9W4ldnqWzi29KAITx4a0LBYB5D3YKL8VAcvkwAl0OqsIHMIdt4Y/Q2Cc q1JPQyDGmfwOUmixwow== X-Proofpoint-ORIG-GUID: bQsBmrjEBBnqbtRioGoaiEPQgPyPoO3e X-Proofpoint-GUID: bQsBmrjEBBnqbtRioGoaiEPQgPyPoO3e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130192 On 5/11/2026 2:50 PM, Neil Armstrong wrote: > The 10bit pixel format can be only used when the decoder identifies the > stream as decoding into 10bit pixel format buffers, so update the > find_format helper to filter the formats and only allow the proper > formats when setting or trying a capture format. > > Signed-off-by: Neil Armstrong > --- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 + > drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 5a489917580e..cd3509da4b75 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -18,6 +18,7 @@ struct iris_inst; > > #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma)) > #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8) > +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10) > #define CODED_FRAMES_PROGRESSIVE 0x0 > #define DEFAULT_MAX_HOST_BUF_COUNT 64 > #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256 > diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c > index eea69f937147..f4d9951ed04c 100644 > --- a/drivers/media/platform/qcom/iris/iris_vdec.c > +++ b/drivers/media/platform/qcom/iris/iris_vdec.c > @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type) > if (i == size || fmt[i].type != type) > return NULL; > > + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > + if (iris_fmt_is_8bit(fmt[i].pixfmt) && > + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) > + return NULL; > + > + if (iris_fmt_is_10bit(fmt[i].pixfmt) && > + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) > + return NULL; > + } similar logic would be now needed while enumerating fmt. VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C, QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will reject the wrong-depth formats. userspace will see formats via ENUM_FMT that it cannot successfully set with S_FMT. > + > return &fmt[i]; > } > > Regards, Vikash