From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9524434F476 for ; Wed, 28 Jan 2026 12:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769603967; cv=none; b=p9r4aoHApcAWT/vSaJIvpm+k7gVvgbpmy2yjmkWjbhDYo3ZsUlo0bPMfkVb1pXfx7SusDPnXLEDgddL0LuAyBMPshoX846rrI8ANRXrD+Us/rsMRGcfDMf0gajd+Rh0WZUPbcyuKWgUcmnGvXYslhDQJ+pIdy0Atl8Mc52YTSXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769603967; c=relaxed/simple; bh=rnSFYiKpipLYfYsB7I4jYi2KJwlBXa6QxCsWGp3+S5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=awuBwDcAe76CXMbsU7tEQIZuq7Fx4Rdg8CucV1yV9/erYDSJGbAgUN1aXGDjGgpRtng7GZ99kY/cyIi+EOQEm99cyj5KxrUhWCgi72r7wBlLxjqpkWeqHUoNGqbJeuN6G/0L5vFkB7aZwLey5I5ogjj9lP87/omDtu068pt93nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V5n28WXB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a1sjthdd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V5n28WXB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a1sjthdd" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S92d95042005 for ; Wed, 28 Jan 2026 12:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zuk0aNNm3PN/IEIs187jYGxFLJiqS4HGWXcW5xEcOl0=; b=V5n28WXBnCDbknJT GZh9mo6ev1aaCAVBfNhLRqHRJW7DpYWx0Uwqj4hN3uEu7OjjaH/WYtYoxc2B2fI9 XCTIlejLqkHPHaKUj1gxW5+v/O2eo5ld8f1avzA8tNSrjC4O282nYG5n8t4wbhtN b4bSpKquj8bUQCD/rPR6wTZelPbHiIhHY6QzplBT+2mRKSVjL3zJ28OgIqFmZ8YJ EzM60LgzV3H/BQH+ZynWsHSB/ap04IjDiQjnGQF/VUyj8VvjE8d5FYaCJpZtHPtO 83AUfVp3cvAVJclZ7+MSO2hlD6uDv0yQtbHbb9KT1+BssJS0a3Xy6LVMny21eYj0 CKnJvw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by355u27q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 12:39:25 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a262380deso18923866d6.1 for ; Wed, 28 Jan 2026 04:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769603965; x=1770208765; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zuk0aNNm3PN/IEIs187jYGxFLJiqS4HGWXcW5xEcOl0=; b=a1sjthddU3BVCEpw7pwOKvf2vHyR5yslccJ523Z7li3DuGn1c1CEv+r/jKvXNDBENb i+MMykFTvhmOqe7EePD2P7HaZqcDqw/wKJI8mkrS1g8tWkPM/jsuiFziy3AvGu3deKdD 4N/be38pE0Yzg7GXP5+n7vrhzAT9sLednIOtcyOfwpI/TOuW4NbguCgorGQdNB3NLlA9 x5J1jAwoRfuw+bFdygniPV1EJTvo8bIN9IeZTg1UDW0f3jb6T4Ab8zC/EJ6egbGnuf0s LeE3TCLqBFB1+1OasWUTNb9DEK0yWW2biCIThN9CEUnGuqGX8QJ2afKk/TlgTZvmqR5J 6JNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769603965; x=1770208765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zuk0aNNm3PN/IEIs187jYGxFLJiqS4HGWXcW5xEcOl0=; b=B7pdQXcl21hUDHqXAO77nmmvWtjtAs9qvv/nx+TI11q5iKoZacF+j8NQb81PeRS0OK BuZsbatCKkYRNJiaHHfotDHkbl8CAeeVesvJa5UV+Cgm6Jur7qWGXQpShuEUDrHKXvbh rDWp5WCOmbr0Y0mqDhpgCn4QP3D3BuWBKEoTL0QzOHD/KcvwNyJsyNYWVLb9hYU/oNqL XM3W6/qhlbvW/ZAqD9riAaKQ76FeD+ovLDjsFk3PC96Z4yG9RF0vLSWr59xvdCAM+wYf GzhVcJEynApOUnIHtI6IThoGfdHDK95b3r0Hdcg4UU3Km2doy0hC6wMySZMXIMd1x2Ih JmLA== X-Forwarded-Encrypted: i=1; AJvYcCULatB8lv+V0YV+ggggeiwfix3h1gK4HbiIfH0NIHMoY83XnVTyyNxq4oRZy+rXpfZwV+AC3WV5dZnjeHE=@vger.kernel.org X-Gm-Message-State: AOJu0YyNmsh17rcoT/SGt46iQo+KcGYNwnYYO3QrjPMyE5zwkEoyb7p0 DBpXE98v0ifuD/st2HuWyzA+z2dMgwEhvDKwcmEttuMpbtQYQ4lqTK46XBy/NfAMt44RquWoeaF PoEojXxIdW6rdtW8dPmFJCwNO0ofR3g9dcx3cSB+Y5nNPiu/uhOWCJdCAC4GzO2KI4C0= X-Gm-Gg: AZuq6aKa3wAQpmW7OztJafHHCbIbiFIJM4FxnipCQHpxedHht9dMVodX1Xnkgm9k96F I1+X0XyycKDzRDXnu5MiVje/xRjd+/tScoPONWsmCjQNnboO3YU5zc1fQfCj0TcV7DNX4YVttx7 k/b+ip3Mia3eiwhPdCtN5ErzLrsYPYY1NkdMuvi8qm6x2UkOOQtKXYiTTmXTHeCuDkOVVlysggF 1ZIRxG8dPD/T3kEA5U8ZOtw401jiSs6/sVgMt0h2yKAzyV/slpHhayp7qax9T4Vig3tt435oxDN S2rReUyCPFGMVNJxVCDrFIKirV1WUMr7TXQhd+vD5+pwTOg0iwVI36z03Q0gYoQiDGr5GtAy1Yw 04kW8v3dYk3Cd/+IfZ34tYgJRvhEFEMiZumpfijRpRDE8/yV/j23YuXFAAdTotf9Lb1c= X-Received: by 2002:a05:6214:5e03:b0:894:979a:bf7d with SMTP id 6a1803df08f44-894dccc1b03mr1054866d6.6.1769603964605; Wed, 28 Jan 2026 04:39:24 -0800 (PST) X-Received: by 2002:a05:6214:5e03:b0:894:979a:bf7d with SMTP id 6a1803df08f44-894dccc1b03mr1054486d6.6.1769603964029; Wed, 28 Jan 2026 04:39:24 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4452e98sm1498904a12.12.2026.01.28.04.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 04:39:23 -0800 (PST) Message-ID: <5fcbfcef-5fb4-4d95-b75a-1c425d1c4183@oss.qualcomm.com> Date: Wed, 28 Jan 2026 13:39:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] pinctrl: qcom: Add SM6350 LPASS LPI TLMM To: Luca Weiss , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260128-sm6350-lpi-tlmm-v1-0-36583f2a2a2a@fairphone.com> <20260128-sm6350-lpi-tlmm-v1-3-36583f2a2a2a@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260128-sm6350-lpi-tlmm-v1-3-36583f2a2a2a@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YNWSCBGx c=1 sm=1 tr=0 ts=697a037d cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=FKLYIeIi5cSbgHY3oWEA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: 28lOsbN0VGysA-NUSm1VTycjvy5lC5f6 X-Proofpoint-GUID: 28lOsbN0VGysA-NUSm1VTycjvy5lC5f6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDEwNCBTYWx0ZWRfXz15GE1JRV0D4 XvxAjt6CQ5M1X7VqheoOqj/EKQ71tsGDf5YCmIph9PFK20PxckbVjindXLJUlZyHPY1VT//YFaV +oQ+0VBiWQYwP2N1qLvtffNR2V8l7EGuwEJH0WNTvKyrfxqa2SFRYda4FloiNIk7N7RHUHb3pm3 SFmrn+uJ7Fu2rv0hqUKSAv6+aXb5roucTDQ8BsbdT8PTaFFbZcv6qGvZFcHJQs7F1/lKHVEapxg 55VtlNQ6nAYr7KpGUQvZ9EKg62Fl1mz/CpKhnS+TFDIQbflgnL7dy2nIIAoMfF1M0YIWRlYCkUs J0HU8yNNolIzSDr2kZ4NC2IvYFkpvnEyjK/gUoJd0V0tDuU/YLATREaG5Hgs3A9QcwvJVECuzcs VP9gml2350xAhuCqehFP218NoobgzR9YeyY3NEh0aESD1zRiicPf+TwDpQwoc1AAy6y5DBzPmDc MuA6hYNN5HabskUJeZw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280104 On 1/28/26 1:26 PM, Luca Weiss wrote: > Add support for the pin controller block on SM6350 Low Power Island. > > Signed-off-by: Luca Weiss > --- [...] > +static const struct lpi_pingroup sm6350_groups[] = { > + LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _), > + LPI_PINGROUP(1, 2, swr_tx_data, qua_mi2s_ws, _, _), > + LPI_PINGROUP(2, 4, swr_tx_data, qua_mi2s_data, _, _), > + LPI_PINGROUP(3, 8, swr_rx_clk, qua_mi2s_data, _, _), > + LPI_PINGROUP(4, 10, swr_rx_data, qua_mi2s_data, _, _), > + LPI_PINGROUP(5, 12, swr_rx_data, _, qua_mi2s_data, _), > + LPI_PINGROUP(6, LPI_NO_SLEW, dmic1_clk, i2s1_clk, _, _), > + LPI_PINGROUP(7, LPI_NO_SLEW, dmic1_data, i2s1_ws, _, _), > + LPI_PINGROUP(8, LPI_NO_SLEW, dmic2_clk, i2s1_data, _, _), > + LPI_PINGROUP(9, LPI_NO_SLEW, dmic2_data, i2s1_data, _, _), > + LPI_PINGROUP(10, 16, i2s2_clk, wsa_swr_clk, _, _), > + LPI_PINGROUP(11, 18, i2s2_ws, wsa_swr_data, _, _), > + LPI_PINGROUP(12, LPI_NO_SLEW, dmic3_clk, i2s2_data, _, _), > + LPI_PINGROUP(13, LPI_NO_SLEW, dmic3_data, i2s2_data, _, _), > + LPI_PINGROUP_SLEW_SPARE_1(14, 0, swr_tx_data, _, _, _), Modulo this odd cookie, it's identical to 8250.. but then it messes with all the definitions, so it makes sense to keep it separate I verified all the functions and slew offsets Reviewed-by: Konrad Dybcio Konrad