From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Xunlei Pang <xpang@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Luca Abeni <luca.abeni@santannapisa.it>,
Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
Romulo Silva de Oliveira <romulo.deoliveira@ufsc.br>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks
Date: Mon, 24 Apr 2017 20:51:46 +0200 [thread overview]
Message-ID: <5fd0446b-0c5c-ce82-7e18-c56140e1a83b@redhat.com> (raw)
In-Reply-To: <20170424130043.0b9c9881@gandalf.local.home>
On 04/24/2017 07:00 PM, Steven Rostedt wrote:
>> +static void
>> +update_dl_revised_wakeup(struct sched_dl_entity *dl_se, struct rq *rq)
>> +{
>> + u64 density = div64_u64(dl_se->dl_runtime << 20, dl_se->dl_deadline);
> Hmm, dl_runtime and dl_deadline don't get updated that often. Can't we
> simply keep a static dl_se->dl_density, and update it when dl_runtime
> or dl_deadline get updated? That would get rid of the divide in the
> middle of a wake up call.
Yeah, I agree! Juri also pointed in the same direction, I will add it in
the possible next version ;-).
Thanks for the feedback!
-- Daniel
next prev parent reply other threads:[~2017-04-24 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 15:18 Daniel Bristot de Oliveira
2017-04-24 17:00 ` Steven Rostedt
2017-04-24 18:51 ` Daniel Bristot de Oliveira [this message]
2017-04-24 20:43 ` Daniel Bristot de Oliveira
2017-05-04 14:17 ` Peter Zijlstra
2017-05-04 14:23 ` Peter Zijlstra
2017-05-11 17:07 ` Daniel Bristot de Oliveira
2017-05-04 14:26 ` Peter Zijlstra
2017-05-11 17:08 ` Daniel Bristot de Oliveira
2017-05-11 17:03 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd0446b-0c5c-ce82-7e18-c56140e1a83b@redhat.com \
--to=bristot@redhat.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=romulo.deoliveira@ufsc.br \
--cc=rostedt@goodmis.org \
--cc=tommaso.cucinotta@sssup.it \
--cc=xpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®