mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Colin King <colin.king@canonical.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/xen: add missing \n at end of printk warning message
Date: Mon, 12 Sep 2016 13:31:07 +0200	[thread overview]
Message-ID: <5fd35560-c017-3f1f-016f-932e4796b83e@suse.com> (raw)
In-Reply-To: <20160912102046.25810-1-colin.king@canonical.com>

On 12/09/16 12:20, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The message is missing a \n, add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>  arch/x86/xen/platform-pci-unplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
> index d37a0c7..90d1b83 100644
> --- a/arch/x86/xen/platform-pci-unplug.c
> +++ b/arch/x86/xen/platform-pci-unplug.c
> @@ -61,7 +61,7 @@ static int check_platform_magic(void)
>  		}
>  		break;
>  	default:
> -		printk(KERN_WARNING "Xen Platform PCI: unknown I/O protocol version");
> +		printk(KERN_WARNING "Xen Platform PCI: unknown I/O protocol version\n");
>  		return XEN_PLATFORM_ERR_PROTOCOL;
>  	}
>  
> 

      reply	other threads:[~2016-09-12 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 10:20 Colin King
2016-09-12 11:31 ` Juergen Gross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fd35560-c017-3f1f-016f-932e4796b83e@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®